Giveth-dapp: Add a feature for subscribing to updates for campaigns

[GriffGreen]

My thoughts..
I imagine a subscribe button on each page for Community subscriber, Campaign subscriber, and Milestone subscriber.

Each button would bring up a menu for the user to choose what type of subscription they would like. We can keep it simple with only 3 options.. The user can choose between Donation updates, Project updates, or All updates. the actions that would trigger an email are as follows:

Community Subscriber

• [ ] Donation updates
• When the community receives a donation
• When a campaign listed under that community receives a donation
• When a milestone listed under a campaign supported by said community receives a donation
• [ ] Project updates
• When the community delegates funds to a new campaign and it becomes listed under that community
• When a milestone listed under a campaign supported by said community gets accepted
• When a milestone listed under a campaign supported by said community gets completed
• [ ] All updates

Campaign Subscriber

• [ ] Donation updates
• When the campaign receives a donation/delegation
• When a milestone listed under campaign receives a donation/delegation
• [ ] Project updates
• When a new milestone listed under campaign gets accepted
• When a milestone listed under campaign gets completed
• [ ] All updates

Milestone Subscriber

• [ ] Donation updates
• When the milestone receives a donation/delegation
• [ ] Project updates
• When the milestone is completed
• When the milestone has a new status update
• [ ] All updates

@GriffGreen @markoprljic @aminlatifi What do you think?

The thing im thinking of now is... if someone subscribes to a milestone that is listed under a campaign or community that they are also subscribed to, would they then receive multiple emails to notify them of a donation?

[GriffGreen]

This should be an easy one for bounties :-D

[jurek1oo]

Interesting issue to look at. How do I go on from here, to start working on the "Add a feature for subscribing to updates for campaigns #536" issue?

[GriffGreen]

Well I think @arbreton is the best person to talk to on this... but in general its the same as most open source github projects... you fork the code and begin hacking away ;-D!

I made this issue so i can give some background...

We have an email notification system that is triggered every time a donor's donation is moved and a few other action focused notifications for Campaign Managers, Reviewers and Delegates... but it would be nice to be able to opt into different notifications even if you aren't officially related to a milestone or campaign... if you are just a dude who wants to follow the project and get updates.

So i see the task could be broken up into a few different tasks:

1. Adding a follow button for Campaigns, Milestone's and DAC views
2. Creating the option screen to choose what notification emails you want
3. Hot wiring that into the Email notification system we have already
4. Confirming the text and content for the notification is well written and autofilled with the appropriate data.

[jurek1oo]

Hi Griff,

Thanks for the replay. I know you are on the holiday now, so I keep it
brief. Can you give me a name of one bit of code (eg. EditMilestone.jsx )
which is currently sending out an email notification? I will have more
questions, once you are back on line. Take it easy and replay when you are
back...

Have a good holiday, and power off you laptop;)

Regards,

Jurek Kurianski
[email protected]
[phone]
[phone]

On Fri, Sep 20, 2019 at 1:08 PM Griff Green [e-mail]
wrote:

Well I think @arbreton https://github.com/arbreton is the best person
to talk to on this... but in general its the same as most open source
github projects... you fork the code and begin hacking away ;-D!

I made this issue so i can give some background...

We have an email notification system that is triggered every time a
donor's donation is moved and a few other action focused notifications for
Campaign Managers, Reviewers and Delegates... but it would be nice to be
able to opt into different notifications even if you aren't officially
related to a milestone or campaign... if you are just a dude who wants to
follow the project and get updates.

So i see the task could be broken up into a few different tasks:

1. Adding a follow button for Campaigns, Milestone's and DAC views
2. Creating the option screen to choose what notification emails you
   want
3. Hot wiring that into the Email notification system we have already
4. Confirming the text and content for the notification is well
   written and autofilled with the appropriate data.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Giveth/giveth-dapp/issues/536?email_source=notifications&email_token=AAXX5PTS3MEMNERJ6MNHUZ3QKRSFFA5CNFSM4GGFNJQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7FVVMI#issuecomment-533420721,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAXX5PWOL2CPYYJKDG4WJATQKRSFFANCNFSM4GGFNJQA
.

[arbreton]

Hello @jurek1oo ,

That piece of code is actually not in the giveth dapp, is on the feathers-giveth repository, that functionality is handled by a hook on a milestone patch service, when the status is changed from inProgress to Paid, thats when it triggers the send email action, look into the milestone service hooks you will find that action

Best,
Andre

_{Sent with GitHawk}

[arbreton]

Basically this is the frontend code only, the backend is handled by the feathers-giveth repository
https://github.com/Giveth/feathers-giveth

_{Sent with GitHawk}

[markoprljic]

Where in the UI do we give users the option to Subscribe to updates?

[aminlatifi]

Where in the UI do we give users the option to Subscribe to updates?

@markoprljic There isn't such feature yet, only owners and other related roles receive email. Can you design such button?

[markoprljic]

@aminlatifi I assume updates for the Campaigns right? I don't see anywhere on Campaigns right now that we have Status updates listed. So that means user can subscribe to updates and receives what? What are the activities that they will receive updates for? Can we make a list so that we communicate that clearly to the user before hitting th subscribe button?

[aminlatifi]

@markoprljic We can discuss it, currently we have another issue #1597 in progress @Danibelle @GriffGreen and @horus2021 are working on it. We can deduce from the outcome of that issue what would be the items.

[markoprljic]

Ok

On Sun, Jan 17, 2021, 12:52 Amin Latifi [e-mail] wrote:

@markoprljic https://github.com/markoprljic We can discuss it,
currently we have another issue #1597
https://github.com/Giveth/giveth-dapp/issues/1597 in progress @Danibelle
https://github.com/Danibelle @GriffGreen https://github.com/GriffGreen
and @horus2021 https://github.com/horus2021 are working on it. We can
deduce from the outcome of that issue what would be the items.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Giveth/giveth-dapp/issues/536#issuecomment-761799363,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABLQUXI5JEJMEBJC5D7HFZLS2LFRLANCNFSM4GGFNJQA
.

[jurek1oo]

Hi Marko,

It has been a long time since I did anything with giveth.
I did give up a bit on giveth, as I have seen that my work has been wasted.

I have tried to convince the key developers that a transaction tracing and
error logging for all elements of the app is a good idea. I have set up
docker images with logstash to centrally log giveth front end web (http)
app errors. There was no interest whatsoever. It looks like developers are
testing the app on users, and use a user error screen capture as an error
report. Key developers generate code without any tests and delegate any
discovered bugs to new "green" developers as a "learning curve". They do
not fix their own mess. Even worse, if you do not log your errors, you find
them at the worst possible time, in the production with a prominent
user/contributor letting you know that you have an issue with the
application. Anyway, enough of my rumbling. You will find out.

I wish the project well, it has a lot of youthful enthusiasm about a
new technology...

Regards, from Hua Hin in Thailand. Keep safe guys.

Jurek Kurianski
[email protected]
[phone]
[phone]

On Sun, Jan 17, 2021 at 6:54 PM markoprljic [e-mail]
wrote:

Ok

On Sun, Jan 17, 2021, 12:52 Amin Latifi [e-mail] wrote:

@markoprljic https://github.com/markoprljic We can discuss it,
currently we have another issue #1597
https://github.com/Giveth/giveth-dapp/issues/1597 in progress
@Danibelle
https://github.com/Danibelle @GriffGreen <
https://github.com/GriffGreen>
and @horus2021 https://github.com/horus2021 are working on it. We can
deduce from the outcome of that issue what would be the items.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/Giveth/giveth-dapp/issues/536#issuecomment-761799363
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/ABLQUXI5JEJMEBJC5D7HFZLS2LFRLANCNFSM4GGFNJQA

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Giveth/giveth-dapp/issues/536#issuecomment-761799521,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXX5PVINRJPAPJ6ZZSDPL3S2LFVDANCNFSM4GGFNJQA
.

[aminlatifi]

Hi Marko, It has been a long time since I did anything with giveth. I did give up a bit on giveth, as I have seen that my work has been wasted. I have tried to convince the key developers that a transaction tracing and error logging for all elements of the app is a good idea. I have set up docker images with logstash to centrally log giveth front end web (http) app errors. There was no interest whatsoever. It looks like developers are testing the app on users, and use a user error screen capture as an error report. Key developers generate code without any tests and delegate any discovered bugs to new "green" developers as a "learning curve". They do not fix their own mess. Even worse, if you do not log your errors, you find them at the worst possible time, in the production with a prominent user/contributor letting you know that you have an issue with the application. Anyway, enough of my rumbling. You will find out. I wish the project well, it has a lot of youthful enthusiasm about a new technology... Regards, from Hua Hin in Thailand. Keep safe guys. Jurek Kurianski [email protected] [phone] [phone] On Sun, Jan 17, 2021 at 6:54 PM markoprljic [e-mail] wrote:
…
Ok On Sun, Jan 17, 2021, 12:52 Amin Latifi @.*> wrote: > @markoprljic https://github.com/markoprljic We can discuss it, > currently we have another issue #1597 > <#1597> in progress @Danibelle > https://github.com/Danibelle @GriffGreen < https://github.com/GriffGreen> > and @horus2021 https://github.com/horus2021 are working on it. We can > deduce from the outcome of that issue what would be the items. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#536 (comment) >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/ABLQUXI5JEJMEBJC5D7HFZLS2LFRLANCNFSM4GGFNJQA > > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#536 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXX5PVINRJPAPJ6ZZSDPL3S2LFVDANCNFSM4GGFNJQA .

Hi @jurek1oo
I appreciate your contribution and intention to make Giveth 1 a reliable product. You kindly create dockers (not just one as far as I remember) and thats a futuristic action since we have plan to change our infrastructure and migrate from running services directly on the servers.
The major reason your contribution has not been integrated is that we haven't set up appropriate infrastructure to host such dockers and we haven't yet designed it. We have had serious obvious bugs and demanding features to implement, and lack of resources stopped us to fix them soon.
At the time or writing we have recruited new devs and have opportunity to think beyond, the main priority is to make a plan and manage activities to align roadmap, of course your feedback is a precious help on it.

[GriffGreen]

Smaller scope than the original issue...

We just need a design for how anyone can subscribe to updates from a campaign.

[markoprljic]

@aminlatifi suggestions where best to put this?
I was considering somewhere at the top in header of campaign page. What do you think?

[markoprljic]

Proposal for Subscribe to updates.

On DAC / Campaign page put the link:

• in the header below Donate button OR
• in the sub nav next to secondary navigation

Clicking on the link triggers a popup with subscribe options:

On the Milestone page, under Status updates put a button to Subscribe to updates (which triggers the same modal as shown above):

[aminlatifi]

Proposal for Subscribe to updates.

On DAC / Campaign page put the link:

• in the header below Donate button OR
• in the sub nav next to secondary navigation

Clicking on the link triggers a popup with subscribe options:

On the Milestone page, under Status updates put a button to Subscribe to updates (which triggers the same modal as shown above):

---

@markoprljic I am happy with button location for milestone
but for Campaign and DAC it should not be in navigation I believe! and below donate button not my first choice.

[markoprljic]

For Campaign then we can add it below the sub nav like this:

[GriffGreen]

Backend needs a redesign...

[GriffGreen]

1702 #1704 #1703 and #1722 are related

[GriffGreen]

@WhyldWanderer when people subscribe to a should receive emails when they do any of these things:

Which of these should we give the option to the user to subscribe? Are there others?

I would like to follow this campaign and get an email every time there is a:
Donation to the Campaign (yes/no)
Milestone Proposed (yes/no)
Milestone Accepted (yes/no)
Donation to any Milestone (yes/no)
Milestone completed (yes/no)
Milestone reviewed (yes/no)
Campaign text is edited (yes/no)
... EVERYTHING WE CAN THINK OF ;-)

[GriffGreen]

Milestone Accepted (yes/no)
Donation to the Campaign (yes/no)

Needs to be options

[markoprljic]

These options look like too much to me, I mean for the user to edit the
settings. Yes, we could have that in their account maybe, but for
subscribing I only put three options:
Project updates
Campaign updates
Milestone updates

On Mon, Feb 1, 2021 at 5:43 PM Griff Green [e-mail] wrote:

Milestone Accepted (yes/no)
Donation to the Campaign (yes/no)

Needs to be options

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Giveth/giveth-dapp/issues/536#issuecomment-770992203,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABLQUXPITJ422BCHKXLOWBTS43K3ZANCNFSM4GGFNJQA
.

--
Marko Prljić

Design Scientist

Website: http://www.markoprljic.com
Dribbble: http://markoprljic.dribbble.com
Twitter: http://twitter.com/markoprljic
LinkedIn: http://linkedin.com/in/markoprljic

[WhyldWanderer]

My thoughts..
I imagine a subscribe button on each page for Community subscriber, Campaign subscriber, and Milestone subscriber.

Each button would bring up a menu for the user to choose what type of subscription they would like. We can keep it simple with only 3 options.. The user can choose between Donation updates, Project updates, or All updates. the actions that would trigger an email are as follows:

Community Subscriber

• [ ] Donation updates
• When the community receives a donation
• When a campaign listed under that community receives a donation
• When a milestone listed under a campaign supported by said community receives a donation
• [ ] Project updates
• When the community delegates funds to a new campaign and it becomes listed under that community
• When a milestone listed under a campaign supported by said community gets accepted
• When a milestone listed under a campaign supported by said community gets completed
• [ ] All updates

Campaign Subscriber

• [ ] Donation updates
• When the campaign receives a donation/delegation
• When a milestone listed under campaign receives a donation/delegation
• [ ] Project updates
• When a new milestone listed under campaign gets accepted
• When a milestone listed under campaign gets completed
• [ ] All updates

Milestone Subscriber

• [ ] Donation updates
• When the milestone receives a donation/delegation
• [ ] Project updates
• When the milestone is completed
• When the milestone has a new status update
• [ ] All updates

@GriffGreen @markoprljic @aminlatifi What do you think?

The thing im thinking of now is... if someone subscribes to a milestone that is listed under a campaign or community that they are also subscribed to, would they then receive multiple emails to notify them of a donation?

[markoprljic]

@WhyldWanderer Did you see the mockup I posted above? https://github.com/Giveth/giveth-dapp/issues/536#issuecomment-767549367

It is very close to what you're suggesting, except for labels.

The updates breakdown for each category should be available in the user account to edit and save changes.

[jurek1oo]

Hi Marko,

I am not sure you guys want my two cents.

What is the point of storing personal information (emails, etc.) in a
database which is not guaranteed to be ACID. You get exposed from
legal point, unless users sign a disclaimer that they don't care about
it.

https://dzone.com/articles/how-acid-mongodb

Jurek Kurianski
[email protected]
[phone]
[phone]

On Tue, Feb 2, 2021 at 10:29 PM markoprljic [e-mail] wrote:
>

@WhyldWanderer Did you see the mockup I posted above? #536 (comment)

It is very close to what you're suggesting, except for labels.

The updates breakdown for each category should be available in the user account to edit and save changes.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

[WhyldWanderer]

@markoprljic I did see your suggestion and I think its a good idea not to have too many options.
And having the breakdown available somewhere so that the settings can be changed.

[horus2021]

This issues (task) is related to #1700 Email Notification Overhaul Epic (Supertask). See Column N, O, P of the below sheet.
https://docs.google.com/spreadsheets/d/1gqyb8_ATVbbu0Xi2DjINyXBMvpznlsKcUUrp_dutg1A/edit#gid=1084492120

[aminlatifi]

@mohammadranjbarz Please add menus to giveth-dapp, styling doesn't need to be identical can be fixed later