Giveth-dapp: Make Manage pages paginated
Task:
Make the My Donations, My Delegations, My Campaigns and My Communities paginated the same way as the My Milestone page is.
Work Estimate:
2-4h
Original description:
https://etherscan.io/tx/0x66bc674ddb2d2c142462c0eb2ad4ed1f5d99cd4fec87c23d7dba72b8bc53fb86
Not in my delegations... likely related to: https://github.com/Giveth/giveth-dapp/issues/467
GriffGreen
All 19 comments
Make the My Donations, My Delegations, My Campaigns and My Communities paginated the same way as the My Milestone page is.
vojtechsimetka
on 24 Oct 2018
Will do this after #462
anshumanv
on 25 Oct 2018
@anshumanv @vojtechsimetka i am starting to have troubles managing my campaigns... i can't access any funds donated to me after 10/12 :-( trying to clear as many delegations as possible but not making much progress.. I can't pay out Aragon DAC people because this and the delegate button doesn't work :(
GriffGreen
on 10 Nov 2018
I was able to get rid of some donations and get to the Aragon DAC donation... but the Tennagraph donation is still unaccessible :-( Is this up for a bounty yet? @vojtechsimetka
GriffGreen
on 13 Nov 2018
Hey @GriffGreen almost finished up with fixing the delegate button, will tackle this after delegate button PR is finalized, sorry for the delay.
anshumanv
on 13 Nov 2018
no worries! the delegate button will also fix my issue :-D
GriffGreen
on 13 Nov 2018
Yeah I asked @anshumanv to prioritize this issue.
vojtechsimetka
on 13 Nov 2018
Funding this now for @anshumanv :)
ceresstation
on 14 Nov 2018
Issue Status: 1. Open 2. Started 3. Submitted 4. Done
__This issue now has a funding of 200.0 DAI (200.0 USD @ $1.0/DAI) attached to it as part of the ECF fund.__
- If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
- Want to chip in? Add your own contribution here.
- Questions? Checkout Gitcoin Help or the Gitcoin Slack
- $46,952.85 more funded OSS Work available on the Gitcoin Issue Explorer
gitcoinbot
on 14 Nov 2018
Issue Status: 1. Open 2. Started 3. Submitted 4. Done
__Work has been started__.
These users each claimed they can complete the work by 2Â months, 3Â weeks ago.
Please review their action plans below:
1) anshumanv has been approved to start work.
Working on this!
Will make all the requested pages paginated.
Learn more on the Gitcoin Issue Details page.
gitcoinbot
on 14 Nov 2018
Scott you are a god damn hero
GriffGreen
on 14 Nov 2018
@anshumanv Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
- [x] reminder (3 days)
- [ ] escalation to mods (6 days)
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days
gitcoinbot
on 20 Nov 2018
Submitted PR some days back, waiting for review.
Please see @vojtechsimetka
anshumanv
on 20 Nov 2018
@ceresstation This has been delivered and merged. Will go out in the next release, thank you very much for funding this issue!!!
Merged in 48f2441cc602d0e36070ae18779d2790040f1b36
@anshumanv I've accepted it because we are trying to make new release (and this part will be changed soon) but please next time make it more universal. This screams HOC as the pagination is shared across multiple pages. Being smart here means writing less repetitive code :) .
vojtechsimetka
on 21 Nov 2018
Issue Status: 1. Open 2. Started 3. Submitted 4. Done
__Work for 200.0 DAI (200.0 USD @ $1.0/DAI) has been submitted by__:
@ceresstation please take a look at the submitted work:
- PR by @anshumanv
- Learn more on the Gitcoin Issue Details page
- Want to chip in? Add your own contribution here.
- Questions? Checkout Gitcoin Help or the Gitcoin Slack
- $39,238.21 more funded OSS Work available on the Gitcoin Issue Explorer
gitcoinbot
on 21 Nov 2018
Issue Status: 1. Open 2. Started 3. Submitted 4. Done
__The funding of 200.0 DAI (200.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @anshumanv.__
- Learn more on the Gitcoin Issue Details page
- Questions? Checkout Gitcoin Help or the Gitcoin Slack
- $36,516.95 more funded OSS Work available on the Gitcoin Issue Explorer
gitcoinbot
on 24 Nov 2018
Some how this was reverted @perissology @vojtechsimetka
GriffGreen
on 27 Dec 2018
@GriffGreen Are you sure? Because the code still has those but I don't have enough items on beta to check :)
E.g. https://github.com/Giveth/giveth-dapp/blob/master/src/components/views/Donations.jsx#L163
vojtechsimetka
on 27 Dec 2018
it works
ewingrj
on 23 Jan 2019
Related issues
MoeNick
·
5Comments
vojtechsimetka
·
7Comments
GriffGreen
·
3Comments
mohammadranjbarz
·
4Comments
GriffGreen
·
3Comments
Most helpful comment
@ceresstation This has been delivered and merged. Will go out in the next release, thank you very much for funding this issue!!!
Merged in 48f2441cc602d0e36070ae18779d2790040f1b36
@anshumanv I've accepted it because we are trying to make new release (and this part will be changed soon) but please next time make it more universal. This screams HOC as the pagination is shared across multiple pages. Being smart here means writing less repetitive code :) .