Gitversion: Consolidate AssemblyInfo update logic

Created on 26 May 2016  路  9Comments  路  Source: GitTools/GitVersion

I added a few TODOs in cb4698d72b8d7aca6087769dfa402472abc3e9bc for consolidation of the AssemblyInfo update logic in GitVersionTask and GitVersionExe that should be tackled. There's quite a bit of duplicated functionality that leads to diverging support for different features and bugs in the task that might be well tested in the .exe and vice versa. Consolidating all of this into GitVersionCore with accompanying tests would be neat.

help wanted improvement pinned

All 9 comments

This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs. Thank you for your contributions.

This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs. Thank you for your contributions.

Came here from #1319, bumping to "un-stale".

@asbjornu what is left with this issue?

@stunney, pretty much everything I wrote in the issue desription is still applicable.

@asbjornu I think we can close this one, as we moved the logic for AssemblyInfo update into GitVersion.Core, and both the GitVersionTask and GitVersionExe are using the same class

Is 55d066462c21acf02fd6a1a15ff5707317850ce5 the commit that did the consolidation, @arturcic?

yes

Ok. Closing as resolved in 55d066462c21acf02fd6a1a15ff5707317850ce5.

Was this page helpful?
0 / 5 - 0 ratings