Gitversion: Fix the version numbers for beta versions of GitVersion
Because the beta releases are not padded, they return the wrong version.
e.g. If I want latest, I get Beta3+4 instead of Beta3+35 because it's sorted A-Z!
.\nuget install GitVersion.CommandLine -ExcludeVersion -PreRelease -OutputDirectory /tools
Should it follow the GitVersion schema instead of 0035 ?
mikeblakeuk
All 3 comments
Are you in a position to make a PR?
arturcic
on 27 Jun 2019
After reading the following blog post, the documentation, and https://github.com/NuGet/Home/issues/1359#issuecomment-328519398, I conclude that the mistake here must be that we use - as a separator instead of a .. I believe 5.0.0-beta3.35 should be sorted as higher/newer than 5.0.0-beta3.4. A PR to fix this would be highly appreciated. 馃檹
asbjornu
on 27 Jun 2019
👍2
fixed in 893d6e4d5d97c04e15d8b03d8689b3a993f93baa
arturcic
on 4 Jul 2019
❤1
Was this page helpful?
0 / 5 - 0 ratings
Related issues
bording
路
3Comments
Bhaal22
路
5Comments
kpanwar
路
3Comments
pcoombe
路
5Comments
Caleb9
路
3Comments
Most helpful comment
After reading the following blog post, the documentation, and https://github.com/NuGet/Home/issues/1359#issuecomment-328519398, I conclude that the mistake here must be that we use
-as a separator instead of a.. I believe5.0.0-beta3.35should be sorted as higher/newer than5.0.0-beta3.4. A PR to fix this would be highly appreciated. 馃檹