Hello @carloscuesta :sunglasses:!
I want to suggest the following addition to Gitmoji:
:passport_control:Hello,
Isn"t this covered by :lock: ?
Hi @KaKi87
:lock: :lock: is "Fix security issues", which is different from authorization/permissions work. E.g., changing the scope access available to a certain user-type on the website, doesn't necessarily fix a security issue, just changes what certain users have access to.
I understand. Then it's a matter of how significantly does it matter compared to using :sparkles:.
I believe the point of using gitmoji is to express clear intent in a visual, obvious way. I think that :passport_control: achieves that better than :sparkles: in this case, since changing the scope access might not look like a new feature, at least not from the user point of view.
Love the idea of this gitmoji which can be really useful in backend (middleware creation/update) and in frontend (add auth page).
IMHO looks ๐ :guard: a little better and the shortcode has less characters ๐
Thanks for the feedback @johannchopin !
Yeah, that could work as well. Although, personally, I think :passport_control: fits authorization semantics slightly better, as it conveys the idea that your credentials are being checked, before you are allowed to take an action.
Also, :guard: has additional meanings in software world, as in "guard conditions" and there is also the ruby guard "file changes observer" project.
But generally, both could work.
Let's see the support of both guard and passport_control emojis on GitHub GitLab and BitBucket to decide which one we pick
| | :passport_control: | :guard: | :guardsman: |
| :--------- | :-----------: | :----------: | :----------: |
| GitHub | โ
| โ
| โ
|
| GitLab | โ
| โ | โ
|
| BitBucket | โ
| โ
| โ |
| Gitea | โ
| โ
| โ
|
So I guess :passport_control: won the game ๐
Just so you know, Gitea supports the 3 of these. I think it's an interesting platform to add to comparisons in general ๐
Let's go with that one then :passport_control:
@mikemarsian So do you want to add the gitmoji?
My bad, here is the PR: https://github.com/carloscuesta/gitmoji/pull/602
Already shipped ๐
Most helpful comment
Just so you know, Gitea supports the 3 of these. I think it's an interesting platform to add to comparisons in general ๐