Gitmoji: Removing 🍎, 🐧, 🏁, πŸ€– and 🍏

Created on 29 May 2020  Β·  15Comments  Β·  Source: carloscuesta/gitmoji

Hello @carloscuesta :sunglasses:!

All this mentioned gitmojis are very platform specific which seems to not be a good practice in the gitmoji's convention. For example it would make no sense to add the 🍏 gitmoji in front of all commit's message of an ios app don't you think?

The 'fixing' action should be covered by :bug:, :lock: or :green_heart:

breaking-change emoji

Most helpful comment

Yes I agree with that, doesn't makes sense to have those platform specific emojis

All 15 comments

What about using the action emoji + the platform emoji in case of working on a multiplatform project but commiting changes affecting only a specific platform ?

@carloscuesta himself don't really recommend to use multiples gitmoji as you can read here:

The β€œspecification” for me If you want to call it like that is the following one

β€œ[Emoji] [Title]”

Well, it's a comment, not a wiki or a readme, and it doesn't explicitly says that multiple emojis isn't recommended.

You're right and probably it's better to keep them. Let's see what @carloscuesta thinks about it :+1:

(option) I don't like the idea of using two emojis, my take on it is, if you can use two emojis on one commit, it is not atomic enought. And I like my commits atomic (helps with cherry-picking).

Of course in those cases this atomicity doesn't really apply, but I think It's a good thing to have a specification :D

The case I like to share the most when talking about gitmoji is when I wanted to do a cherry pick of assets, and I couln't remember the commit title, but being an asset commit, I searched for :bento: and found it in under 2 seconds.

So I think thats one of the great strenghts of gitmoji. What we have to ask ourselfs is: If we're looking for a specific commit, does 🍎 🍏 🏁 🐧 πŸ€– would helped us in that situation?

My personal answer to that question is: If I used one of those once, it was a lot; If I'm making an android app, does all my fixes commits always have to have the πŸ€– emoji? I don't think they are that usefull.

but you know, before introducing any breaking change, we should really adopt semver.

I think projects like gitmoji-cli or other tools would benefit a lot by having the "gitmoji.json" properly versioned.

Edit:
There is also this issue which is very aligned with this concern of mine.

Yes I agree with that, doesn't makes sense to have those platform specific emojis

Are 🐳 and ☸️ also like the others not specific enough? πŸ€”

Not sure about the docker and k8s ones πŸ˜“

maybe we could add some more emojis related to CI/CD creating and configuration and deprecate :whale: / :wheel_of_dharma: ? just an idea (cuz I really like the :whale: haha :sweat_smile:)

but you know, let's be explicit here, are we going to remove :apple: :green_apple: :checkered_flag: :penguin: :robot:?

EDIT: grammar

but you know, let's be explicit here, we are going to remove apple green_apple checkered_flag penguin robot?

but you know, let people choose the emoji they want, keep them :rofl:

Are whale and wheel_of_dharma also like the others not specific enough? thinking

Should emojis be dependant of the product/software name or the general concept ?

So we have decided to remove those (see #452), will put on kanban.

Close this issue since it's covered by #452.

Was this page helpful?
0 / 5 - 0 ratings