Gitmoji: ❎ For fixing broken tests
Hello @carloscuesta :sunglasses:!
- Emoji: :negative_squared_cross_mark:
- Code:
:negative_squared_cross_mark: - Description: Fixing broken tests
We currently have ✅ for adding tests, but none for fixing said tests
:negative_squared_cross_mark: Feels like it would fit better than :x: since the green color better communicates that the commit _fixes_ them
emoji
AnthonyLenglet
👍2
All 3 comments
I just had a similar idea. But I thought about just updating the description from ✅ Adding tests. to ✅ Updating tests. as this implicitly also includes fixing broken tests. This would be easier to handle than having two different emojis for quite similar things.
dcastil
on 1 Dec 2018
👍3
This is what I do too @dcastil
BrendanFDMoore
on 21 Dec 2018
Makes sense!
Feel free to send a PR ❤️
carloscuesta
on 9 Feb 2019
Was this page helpful?
0 / 5 - 0 ratings
Related issues
eliorc
·
12Comments
foosel
·
14Comments
johannchopin
·
18Comments
vhoyer
·
16Comments
DanielHilton
·
13Comments
Most helpful comment
I just had a similar idea. But I thought about just updating the description from
✅ Adding tests.to✅ Updating tests.as this implicitly also includes fixing broken tests. This would be easier to handle than having two different emojis for quite similar things.