Github: Git Diffs Are Hard to Read in 1.34 (Possibly theme specific)

[framerate]

Prerequisites

• [x] Put an X between the brackets on this line if you have done all of the following:
  
  
  
  • Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
  
  
  • Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
  
  
  • Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
  
  
  • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
  
  
  • Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages
  
  

Description

Using the Bliss theme, the new git-diff is very hard to visually follow. (Bug report requested by @annthurium via twitter!

1.32 looked like this:

1.34 looks like this:

Steps to Reproduce

1. Install Atom + Bliss Theme
2. Look at the ugly
3. (Thank everyone at atom for their hard work!)

Expected behavior: The diff should be super easy to visually grep

Actual behavior: I end up using an external program for my diffs!

Reproduces how often: 100%

Versions

You can get this information from copy and pasting the output of atom --version and apm --version from the command line. Also, please include the OS and what version of the OS you're running.

Atom : 1.34.0 Electron: 2.0.16 Chrome : 61.0.3163.100 Node : 8.9.3

Using MacOS 10.14.3

Additional Information

Bliss UI Theme
Bliss SyntaxTheme

[annthurium]

thanks for the report, @framerate !

this is an atom/github issue so I'm going to move the conversation over there.

[framerate]

Oh, as opposed to githib(.com)/atom! My bad! Thanks @annthurium!

[rsese]

I was poking at atom/atom issues so went ahead and transferred the issue over, hope that's ok @annthurium :v:

[annthurium]

hi @framerate --

I dug into this a bit. It is definitely a theme specific issue.

As a temporary workaround, you can add some custom css to your styles.less folder in your ~/.atom dorectory:

  .github-FilePatchView-line--added {
    background: #4F5B66;
    // bliss green
    color: #a3be8c;
  }

  .github-FilePatchView-line--deleted {
    background: #4F5B66;
    // bliss red
    color: #bf616a;
  }

and that makes it look...not perfect but definitely somewhat more readable 😄

As a long term fix, the maintainer of the community theme will need to update the class names in their style sheets, and that should resolve the problem. So I would suggest filing an issue with them.

Another workaround that I am hesitant to suggest, because themes are so personal, but you could also change to one of Atom's officially supported themes. Not sure how attached you are to yours.

Let me know if you have any additional questions.

[framerate]

Nice!

Is there a tutorial on "migrating themes to 1.34" you can point me at? I can probably fork the theme and issue a PR, because as you correctly assumed... I'm rather attached to this one right now :)

[annthurium]

We don't have a tutorial -- I did not know that there were community themes that styled the git diff view within atom. 😮 But yeah, if this problem is more widespread we should put some guidelines out.

I suspect that changing all instances of .github-HunkView-line to .github-FilePatchView-line will get you most of the way there, although you may have to fiddle with the selectors a bit.

The code that the github package uses to style the diff view is here, in case that's helpful to refer to:
https://github.com/atom/github/blob/master/styles/file-patch-view.less

and the pr that introduced this regression is here (but uhh, it's a really big pr just to warn you):
https://github.com/atom/github/pull/1512/files

Good luck, and let me know if there are any other questions I can answer -- I'm happy to help.

[framerate]

Thank you @annthurium! I'll take a look as soon as I get some downtime from writing my own code :P

And thank you for reminding me why I stick with Atom :)

[saadq]

Hey, creator of bliss-ui/bliss-syntax here. Thanks for alerting me of this issue, it should be fixed now. And thanks very much @annthurium for taking the time to help out.

[framerate]

Thank you everyone! Tomorrow will be a much nicer code day since I can go back to my favorite syntax! ♥️

[annthurium]

yay, thanks @saadq and @framerate for being so kind and understanding.

Going to close this out now but please reopen if you have any additional questions or concerns. Happy to chat about theme stuff anytime so don't hesitate to ping me. 😄