Github: The merged commit text on a PR is squished together

Created on 23 Sep 2018  路  2Comments  路  Source: atom/github

Description

After merging a PR, the merge commit is text is squished together, as seen in the actual behavior section of this issue.

Steps to Reproduce

  1. Add the tracks repo - it's public - as a project folder to atom
  2. Open test/controllers/search_controller_test.rb with Cmd-T
  3. Open the GitHub tab (Ctrl-Shift-8)
  4. Select PR 2117 from the list of pull requests to open the PR view
  5. Scroll down to the section of the pane that contains the merge indication

Expected behavior:

Expected the text to be merged commit as in this doctored screenshot:
doctored screenshot expected behavior

Actual behavior:

screenshot of actual behavior

the text mergedcommit is squished together rather than being displayed as merged commit

Reproduces how often:

Always.

Versions

Running on OS X 10.13.6

atom-github package version screenshot

$ atom --version
apmAtom    : 1.30.0
Electron: 2.0.5
Chrome  : 61.0.3163.100
Node    : 8.9.3
$ apm --version
apm  1.19.0
npm  3.10.10
node 6.9.5 x64
atom 1.30.0
python 2.7.15
git 2.18.0

Additional Information

I looked into the code for this briefly, and it looks like the UI in question is rendered here:
https://github.com/atom/github/blob/10d4dd2b1e5bf12cc092ab0fdc7b44ddf5f6b6d2/lib/views/timeline-items/merged-event-view.js#L30-L32

I'm not familiar enough with React to know how to handle this particular situation but would be happy to follow guidance or pair with someone on a fix. 馃檪

Thanks for your attention! :heart:

bug triaged

Most helpful comment

thanks for reporting! I have an Atom community member looking for a good first issue, so I'm going to work with her on resolving this bug.

All 2 comments

Thanks @mattr- :v: Just dropping in to mention I can reproduce on macOS 10.12.6 and 1.33.0-nightly0.

thanks for reporting! I have an Atom community member looking for a good first issue, so I'm going to work with her on resolving this bug.

Was this page helpful?
0 / 5 - 0 ratings