Github: Unstaged & Staged Changes tabs no longer autoclose after staging and commit

[davet-ifit]

Prerequisites

• Have you tried to reproduce the problem in [Safe Mode][safe-mode]? Yes
• Have you followed all applicable steps in the [debugging guide][debugging-guide]? Yes
• Have you checked the FAQs on the [message board][message-board] for common solutions? Yes
• Have you checked that your issue [isn't already filed][already-filed]? Yes

Description

I recently upgraded to address a different issue and found that the behaviour of the "Unstaged Changes" and "Staged Changes" tabs has changed.

I've come across a number of issues which may be related (see #1160 and #391 in particular), but none seem to address this change, which appears to have come about recently. I've also searched for a change log, but I can't find one in this repository.

Steps to Reproduce

Here's what I do and what I'm seeing:

1. edit a file & save it
   
   
   
   • the file appears in the "Unstaged Changes" section of the Git Tab
   
   
2. double-click the file in the "Unstaged Changes" section
   
   
   
   • a new tab opens in the editor with the title "Unstaged Changes: path/to/file". It briefly contains the list of unstaged changes, then changes to "File has no contents"
   
   
   • the file appears in the "Staged Changes" section of the Git Tab.
   
   
   • Expectations I expect the "Unstaged Changes: path/to/file" tab to close. This is what it used to do. Instead, I have to manually close the tab.
   
   
3. click the file in the "Stage Changes" section of the Git Tab
   
   
   
   • the "Unstaged Changes" tab changes to "Staged Changes: path/to file". It contains the staged changes.
   
   
4. add a commit message and press Ctrl-Enter to commit the change
   
   
   
   • *the "Staged Changes: path/to/file" tab becomes empty - it now says "File has no contents"
   
   
   • Expectations I expect the "Staged Changes: path/to/file" tab to close. This is what it used to do. Instead, I have to manually close the tab.
   
   

Reproduces how often:

This happens whenever I attempt to commit when using this version of Atom.

Versions

OS: Kubuntu 14.04.4

Output of atom --version:

Atom    : 1.23.3
Electron: 1.6.15
Chrome  : 56.0.2924.87
Node    : 7.4.0

Output of apm list:

Built-in Atom Packages (92)
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] (disabled)
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
└── [email protected]

Community Packages (16) /home/dthomas/.atom/packages
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
└── [email protected]

[mrintegrity]

I would love to have this feature, it's quite annoying and interrupts my worḱflow to have to manually close the tab every time.

[nurtext]

It's been a while, but I'd like to know if this is getting fixed in the near future

[mediafinger]

Is there any other way to close empty tabs in Atom automatically? As not many people seem to be bothered by this behavior, maybe others are using a workaround?

[NRGLine4Sec]

any update on this ?

[agrossfield]

Problem still there, still annoying. Is there something we're all missing?

[adavie1]

I'll add voice to the chorus for fixing this.