Github: If do not allow the pending pane items, unstaged changes panes will not auto close.

[yubaoquan]

Prerequisites

• Have you tried to reproduce the problem in Safe Mode? yes
• Have you followed all applicable steps in the debugging guide? yes
• Have you checked the FAQs on the message board for common solutions? yes
• Have you checked that your issue isn't already filed? yes

Description

If user don't check the Allow Pending Pane Items selection in Settings/Core pane, after stage a modified file, the Unstaged Changes pane will not auto close, the next Unstaged Changes will not auto show up.

Steps to Reproduce

1. Open a git repo;
2. Open settings>Core, uncheck the Allow Pending Pane Items selection;
3. Modify two files in the repo;
4. Click one item in the right pane of Unstaged Changes;
5. Click Stage File button in the editor;

Expected behavior:

The opened Unstaged Changes pane should close and open another Unstaged Changes pane automatically.

Actual behavior:

The opened Unstaged Changes pane didn't close but became blank and the other pane didn't show up automatically.

Reproduces how often:

100%

Versions

Atom : 1.20.0-beta5
Electron: 1.6.9
Chrome : 56.0.2924.87
Node : 7.4.0

apm 1.18.4
npm 3.10.10
node 6.9.5 x64
python 3.6.1
git 2.11.0

OS: macOS sierra 10.12.6

Additional Information

[hex007]

Reproducible in Atom-beta 1.21 Fedora Linux x64

[Arcanemagus]

This looks related to https://github.com/atom/github/issues/1175.

[zmb3]

Seems related to #391.

For users who don't like enabling pending pane items, the UX is pretty poor and often causes me to resort to the command line or another git tool.

I'd actually be ok with this package operating as if pending pane items were always enabled, or just closing the empty tab if all changes are staged. It's maddening to end up with a pile of empty tabs after staging a few hours worth of work.