Git-updater: Bitbucket credentials not persisting

[bahia0019]

I am using your plugin on a staging site currently: https://staging.thebirdthebear.com/
When it works, it's amazing, but I'm having serious issues with it.

When I log in to check for updates I've made, I get this screen even though I've installed a theme and connected to Bitbucket already, and set it up properly:

I found that if I click Save, the page will refresh, and I'll get this page:

I'll click over to the Bitbucket tab and my theme shows, but I have to re-enter everything, and check that it's Private repo again:

I do:

Hit enter, and this screen displays:

At this stage, the new theme changes on Bitbucket haven't been pulled, and I'm pretty much where I started.
The last couple changes, I've just uploaded via FTP since this hasn't worked.

Happy to provide any information that would help in resolving this.
If you need error logs, or access to the staging site, I'm happy to provide.

[afragen]

What branch and version of the plugin are you using?

[bahia0019]

7.5.0.12
Not sure the branch. I grabbed it from the main repo.

[afragen]

Please use the branch switch to reinstall the latest develop branch and see if the issue persists.

[bahia0019]

Looks like that might have done the trick. I'll push a couple more versions and keep you posted.
Thanks!

[bahia0019]

Hmmm... Not working.
The theme name and the checkbox DO stay at least. But I pushed a new version earlier tonight, hit refresh, nothing. Waited awhile to see if that would help, nothing.

Any chance it's due to using a subdomain for staging? Wild guess.

[afragen]

Can you check out the wiki page on background processing and possibly use the referenced filter hook to bypass WP-Cron processing.

https://github.com/afragen/github-updater/wiki/Background-Processing

[afragen]

Just realized that you are using your email address for the username. This is not correct. You must use your actual username. I know that Bitbucket allows you to log in using your email but the Basic Auth does not.

[bahia0019]

Thanks!
I've fixed this, and will push some stuff later today and update you.
Good catch.

[bahia0019]

Seems to have gone back to the buggy behavior I submitted about.
Everything is missing.

I gotta finish this project. So I'm switching back to FTP.
If you want access to dig further, I'm happy to provide.

[afragen]

I’m sorry it’s not working for you. Do what you need to do for your project. I hope when you have some free time we can figure out the issue.

[afragen]

Is it possible to give afragen read access to the repo so that I can test on my end?

[FORTE-WP]

Hi Andy, thanks for this great plugin. It has helped me for some time now. But I recently seem to have the same problem as William. On refresh the Bitbucket tab disappears. And updates are not carried out anymore. Greetings, Frank

[FORTE-WP]

I've just done some testing. The problem started in release 7.5.0. My website with 7.4.4. is working fine.

[afragen]

I just released 7.6.0. Is this issue still present?

[FORTE-WP]

I'm sorry but it is not resolved in that version. Before I posted I had
already updated.

[afragen]

@FORTE-WP can you start a new issue and describe precisely what you see and how to replicate it?

[afragen]

I think I fixed this issue in https://github.com/afragen/github-updater/commit/8c2fdd30ff39ddb88d4173e7c2dfcb0d5a6cc28d

[afragen]

@bahia0019 can you let me know if the latest release fixes this issue for you? Thanks.

[bahia0019]

@afragen I'll be doing some work on my project tomorrow. I'll push up a few times and give it a good test and report back.

[bahia0019]

@afragen I just pushed a new commit today, and seemed to work fine.
I've got a few more to push a little later tonight, and I'll post back with updates.

[afragen]

Sounds great!

[bahia0019]

I just pushed a new commit, and was going to update it in the Admin, but didn't see Bitbucket again.
Clicked Save, and this is the screen I get now.
So... Still having some issues.

[afragen]

What does the Bitbucket tab look like?

[bahia0019]

It was empty. But I installed the theme yesterday.

[afragen]

This is odd. You are using version 7.6.1 or later and the theme is installed?

Can you check the contents of static::$installed_apis?

[afragen]

Maybe set the scope of $installed_apis from protected to public in Base and see if that does anything.

[afragen]

Can I ask what version of PHP you’re using?

[bahia0019]

Just checked PHP. It's using 7.0
Not sure what static::$installed_apis is.

[afragen]

So when Settings is called it extends class Base. The constructor of Base runs set_installed_apis() and stores the results into Base::$installed_apis.

https://github.com/afragen/github-updater/blob/44a2001098fd54069cd29b584c9c0a10e9727990/src/GitHub_Updater/Base.php#L139-L161

Since Settings extends Base this static should be set. To load all the subtabs Settings::settings_sub_tabs() tests and loads each static::$installed_apis to load that sub tab.

https://github.com/afragen/github-updater/blob/44a2001098fd54069cd29b584c9c0a10e9727990/src/GitHub_Updater/Settings.php#L115-L144

[bahia0019]

Sorry,
Not really sure what I need to do here.
I'm happy to provide access to the staging server, and the WordPress install if you want to run tests. If I get out of the way, you might find answers easier.

Let me know.

[afragen]

As much as I don’t like playing on someone else’s server, I’m game. Please make sure you have backups I don’t want to inadvertently break something. Also, my laptop is out of commission for a few more days so I’ll see what I can see on my iPad. Sorry not ideal.

[bahia0019]

I understand. It is a staging server, only me and the clients see it. I'll let them know too.
What's a good email address? I'll give you WP access and shoot you credentials for cpanel.

[afragen]

andy at thefragens dot com

[afragen]

I was able to log in. The Settings are empty, missing both a GitHub Access Token and Bitbucket credentials.

[afragen]

What did you do to have the GitHub and Bitbucket tabs not show up?

[bahia0019]

Yeah, they were empty when I came back to update. But I did install the theme.
I don't know what I did. I installed the theme. Pushed a change. Everything was fine.
I attempted to do the same today, and the Github and Bitbucket tabs were gone.

[afragen]

So, I re-installed GHU. You’re currently on the master branch. Sometimes there are issues if you don’t correctly rename GHU before installing. Unfortunately I’m not certain where those issues my be. I know one of them is that the Settings link doesn’t show in the plugins.php page next to the Deactivate link.

[bahia0019]

OK, if you need to test more, I'm happy to offer up the staging site.
So, at this point, I just re-add my credentials and keep the "Enable branch switching" checked?

I'll be pushing a couple things tonight. I can keep you updated. Let me know if you need access to anything else.

Thanks!

[afragen]

Just enter your credentials. I deactivated branch switching but you can turn it on if you wish.

[afragen]

Unfortunately what this means is I didn’t see anything not working. Let me know if you see it again and I’ll log in to take a look.

[afragen]

So I now see this error on your site. I’m still without a computer but it gives me a place to start.

I’ve modified the GHU plugin on your site to see if what I think is the the issue really is the issue. You will need to re-enter you Bitbucket credentials.

[afragen]

@bahia0019 I think this is now fixed. I haven’t seen it on the site since I made the transition away from caching the plugin/theme calls. I have switched you back to the master branch as well.

Currently you still need to re-enter your Bitbucket credentials, but I did check the preference for your theme being a private repo and it has persisted.

I’m going to close this issue. Please re-open it if the problem recurs. Thanks for all your help.

As an FYI, the next release ( currently in the develop branch ) adds all the Settings tabs and subtabs via action and filter hooks and so should really eliminate this issue and provide me with a way to keep API specific code more separate. 😉

[bahia0019]

@afragen Hey Andy. I wanted to get back to you on this. I just finished up my project, and pushed a lot in the process. It's super solid. I had absolutely no problems after that update.

Thanks for working on that so hard. This definitely makes things SO much easier. I appreciate your efforts with this plugin!

[afragen]

Thanks for the follow-up.