Git-point: Wrong PR status reported

[machour]

GitPoint displays PR #242 as merged, but it's not merged yet

[lex111]

I can not reproduce this, I updated the master branch, I look at the Android simulator.

@machour give please more details (and check again).

[andrewda]

My guess is that the status was unsuccessfully fetched and did not update from a previous PR. Very strange.

[lex111]

Yes, perhaps we need to figure out how to step-by-step reproduce this bug.

[housseindjirdeh]

Yeah I think @andrewda is right, it's probably persisted data from the previous PR you just visited in the app @machour which was merged. Will try to reproduce this myself as well

[Antoine38660]

I reproduced this one earlier today! And luckily, I was using reactotron :

Step:

• Last repository I opened was Antoine38660/100pompes (private one, without any PR).
• I relauched the app (shift+c and yarn start:ios)
• I looked at #250

I think it's a "cache" issue, is it possible?

[machour]

There's definitely issues with the cache. For example, if you browse to a Repository informations, then to another one, contributors & owner from the previous repository are displayed while the new informations are being loaded.

[Antoine38660]

But, as you can see in the screenshot, some other API endpoint are not affected (GET /repos/gitpoint/git-point/issues/250/comments).

In the .actions.js files, repo information aren't getted in the same way

[andrewda]

Huh, very strange. Another place I've noticed this is repository contributors.

[chinesedfan]

I guess it is something like #315, and I try to solve it in #332. Please check.