Git-point: Console warnings

[andrewda]

On starting up the app, I get this warning several times in my console. Doesn't stop anything from working as it's just a warning, but worth looking into.

GitPoint[1251:177712] Warning: Failed prop type: Invalid props.style key `color` supplied to `RCTView`.
Bad object: {
  "color": "#000000",
  "padding": 15,
  "fontFamily": "AvenirNext-Bold"
}
Valid keys: [
  "display",
  "width",
  "height",
  "top",
  "left",
  "right",
  "bottom",
  "minWidth",
  "maxWidth",
  "minHeight",
  "maxHeight",
  "margin",
  "marginVertical",
  "marginHorizontal",
  "marginTop",
  "marginBottom",
  "marginLeft",
  "marginRight",
  "padding",
  "paddingVertical",
  "paddingHorizontal",
  "paddingTop",
  "paddingBottom",
  "paddingLeft",
  "paddingRight",
  "borderWidth",
  "borderTopWidth",
  "borderRightWidth",
  "borderBottomWidth",
  "borderLeftWidth",
  "position",
  "flexDirection",
  "flexWrap",
  "justifyContent",
  "alignItems",
  "alignSelf",
  "alignContent",
  "overflow",
  "flex",
  "flexGrow",
  "flexShrink",
  "flexBasis",
  "aspectRatio",
  "zIndex",
  "direction",
  "shadowColor",
  "shadowOffset",
  "shadowOpacity",
  "shadowRadius",
  "transform",
  "transformMatrix",
  "decomposedMatrix",
  "scaleX",
  "scaleY",
  "rotation",
  "translateX",
  "translateY",
  "backfaceVisibility",
  "backgroundColor",
  "borderColor",
  "borderTopColor",
  "borderRightColor",
  "borderBottomColor",
  "borderLeftColor",
  "borderRadius",
  "borderTopLeftRadius",
  "borderTopRightRadius",
  "borderBottomLeftRadius",
  "borderBottomRightRadius",
  "borderStyle",
  "opacity",
  "elevation"
]
    in RCTView (created by View)
    in View (created by SectionList)
    in RCTView (created by View)
    in View (created by SectionList)
    in RCTView (created by View)
    in View (created by SectionList)
    in SectionList (created by AuthProfile)
    in RCTView (created by View)
    in View (created by ParallaxScrollView)
    in RCTScrollContentView (created by ScrollView)
    in RCTScrollView (created by ScrollView)
    in ScrollView (created by ParallaxScrollView)
    in RCTView (created by View)
    in View (created by ParallaxScrollView)
    in ParallaxScrollView (created by ParallaxScroll)
    in ParallaxScroll (created by AuthProfile)
    in RCTView (created by View)
    in View (created by ViewContainer)
    in ViewContainer (created by AuthProfile)
    in AuthProfile (created by Connect(AuthProfile))
    in Connect(AuthProfile) (created by SceneView)
    in SceneView (created by CardStack)
    in RCTView (created by View)
    in View (created by CardStack)
    in RCTView (created by View)
    in View (created by CardStack)
    in RCTView (created by View)
    in View (created by AnimatedComponent)
    in AnimatedComponent (created by Card)
    in Card (created by Container)
    in Container (created by CardStack)
    in RCTView (created by View)
    in View (created by CardStack)
    in RCTView (created by View)
    in View (created by CardStack)
    in CardStack (created by Transitioner)
    in RCTView (created by View)
    in View (created by Transitioner)
    in Transitioner (created by CardStackTransitioner)
    in CardStackTransitioner (created by Unknown)
    in Unknown (created by Navigator)
    in Navigator (created by NavigationContainer)
    in NavigationContainer (created by SceneView)
    in SceneView (created by TabViewAnimated)
    in RCTView (created by View)
    in View (created by TabViewAnimated)
    in RCTView (created by View)
    in View (created by TabViewPagerPan)
    in RCTView (created by View)
    in View (created by AnimatedComponent)
    in AnimatedComponent (created by TabViewPagerPan)
    in TabViewPagerPan (created by TabViewAnimated)
    in RCTView (created by View)
    in View (created by TabViewAnimated)
    in TabViewAnimated (created by TabView)
    in TabView (created by withCachedChildNavigation(TabView))
    in withCachedChildNavigation(TabView) (created by Unknown)
    in Unknown (created by Navigator)
    in Navigator (created by NavigationContainer)
    in NavigationContainer (created by SceneView)
    in SceneView (created by CardStack)
    in RCTView (created by View)
    in View (created by CardStack)
    in RCTView (created by View)
    in View (created by CardStack)
    in RCTView (created by View)
    in View (created by AnimatedComponent)
    in AnimatedComponent (created by Card)
    in Card (created by Container)
    in Container (created by CardStack)
    in RCTView (created by View)
    in View (created by CardStack)
    in RCTView (created by View)
    in View (created by CardStack)
    in CardStack (created by Transitioner)
    in RCTView (created by View)
    in View (created by Transitioner)
    in Transitioner (created by CardStackTransitioner)
    in CardStackTransitioner (created by Unknown)
    in Unknown (created by Navigator)
    in Navigator (created by NavigationContainer)
    in NavigationContainer (created by App)
    in Provider (created by App)
    in App
    in RCTView (created by View)
    in View (created by AppContainer)
    in RCTView (created by View)
    in View (created by AppContainer)
    in AppContainer

[lex111]

This occurs here. It is impossible to apply color to View, only to Text, apparently.

Why do you need a condition here, can not we just leave only a View?

[andrewda]

Yup just found that @lex111 :+1: The problem is that we need a <Text> element if title is a string, because we'll get a nasty crash if we have raw text inside a <View>. We should only need the padding: 15 style there, so I'm in favor of just getting rid of all the styles on that view and keeping only the padding.

[housseindjirdeh]

While we have this open, there is another place that a warning pops up and that's in the PullRequestDiff screen. Currently there's a warning that keys aren't applied to a list and will appreciate if someone who takes this on can take a look there too 🙏

[housseindjirdeh]

I think we have these warnings resolved now 💃