Git-point: Have an icon for Fork on the Repo ActionSheet menu

[SammyIsra]

The repository ActionSheet menu currently has Star/Ustar and Fork. The first option has a Star icon to accompany it, but there isn't one for Fork.

[RolfKoenders]

I would suggest we go for the 'git-branch' icon since its really similar and there is no octicon for fork :disappointed:

[andrewda]

@RolfKoenders How about repo-forked?

[SammyIsra]

Is there an example of using octicons in the project? Does anything need to
be imported?

On Jul 24, 2017 12:47 PM, "Andrew Dassonville" [e-mail]
wrote:

@RolfKoenders https://github.com/rolfkoenders How about repo-forked
https://octicons.github.com/icon/repo-forked/?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/gitpoint/git-point/issues/158#issuecomment-317483041,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIjAtJ4D9pHjyr8zecfH4UYuESmU7VwSks5sRMqygaJpZM4OgxQ7
.

[andrewda]

Here's one place where we use them, but not directly. Not sure about getting an octicon into this text area though.

[RolfKoenders]

For some reason i couldn't find it on this page: https://octicons.github.com/ :neutral_face: :sweat_smile:

[andrewda]

@RolfKoenders yea it's not listed with the other ones that looks like it haha

[RolfKoenders]

@andrewda I seriously went 3 times through the list thinking i'm becoming blind :sweat_smile:

[RolfKoenders]

@SammyIsra Appending the icon here would do the Trick.

[housseindjirdeh]

So I simply append a unicode star icon for the Star action and will definitely prefer using octicons instead. However I'm okay if that's going to be a little more work (can ActionSheet take in a component?) to just use an appropriate 'fork' or 'branching' unicode icon for now

[housseindjirdeh]

@SammyIsra as @andrewda mentiones its quite simple to use them for ListItem components as well as placing Icon components in our app (React Native Elements, the UI library we're using, leverages react-native-vector-icons to have all these icons available).

But like I mentioned I'm not sure how simple it would be to have it as part of the ActionSheet hence why I think a simpler unicode icon might just be easier for now

[andrewda]

just use an appropriate 'fork' or 'branching' unicode icon for now

Pretty sure this is the only official fork icon currently on unicode: 🍴

Jokes aside, I think it's probably worth the time to include octicons (or other icons) in the ListItem component to make everything nicer :+1:

[housseindjirdeh]

Haha if that's the only available unicode icon for fork then I agree. Will appreciate if anybody can take a look and see if adding octicons (Icon component) to action sheet is possible

@andrewda ListItem components do accept icons including octicons but you're probably referring to ActionSheet list items :)

[zcei]

Sadly, the underlaying UIAlertAction class (for iOS) only supports custom images via an undocumented property. This is what react-native-actionsheet uses internally.

So for the unicode character I throw OCR Fork into the discussion.

[housseindjirdeh]

Thanks a million @zcei, I think that icon should suffice just fine in that case

[zcei]

Fixed in https://github.com/gitpoint/git-point/commit/023c7f4ae52694f75a1bc9748b072f6f66687b0a

[housseindjirdeh]

Was just about to tag the commit :) Thanks @zcei appreciate it!