Generator-jhipster: JPA Derived Identifier combined with mapstruct generates code that doesn't compile

[murdos]

Overview of the issue

Combination of dto with mapstruct and use of jpaDerivedIdentifier doesn't work.

Motivation for or Use Case

Generated code should compile

Reproduce the error

Use the following JDL:

application {
    config {
        baseName mapsIdBugWithDTO
        applicationType microservice
        databaseType sql
        prodDatabaseType postgresql 
    }
    entities *
}

entity A

entity B

relationship OneToOne {
  A to B with jpaDerivedIdentifier
}

dto * with mapstruct

Because of #10739, once the application and entities have been generated with jhipster import-jdl, you have to manually fix .jhipster/A.json and .jhipster/A.json and regenerate both entities with jhipster entity A --regenerate --force and jhipster entity A --regenerate --force

Then you have multiple compilation errors:

[ERROR] src/main/java/com/mycompany/myapp/web/rest/AResource.java:[55,32] cannot find symbol
  symbol:   method getBId()
  location: variable aDTO of type com.mycompany.myapp.service.dto.ADTO
[ERROR] src/main/java/com/mycompany/myapp/service/AService.java:[49,24] cannot find symbol symbol:   method getBId()
  location: variable aDTO of type com.mycompany.myapp.service.dto.ADTO
[ERROR] src/main/java/com/mycompany/myapp/service/dto/ADTO.java:[56,22] cannot find symbol
  symbol:   method getBId()
  location: class com.mycompany.myapp.service.dto.ADTO
[ERROR] src/main/java/com/mycompany/myapp/service/BService.java:[50,24] cannot find symbol
  symbol:   method getAId()
  location: variable bDTO of type com.mycompany.myapp.service.dto.BDTO
[ERROR] src/main/java/com/mycompany/myapp/web/rest/BResource.java:[56,32] cannot find symbol
  symbol:   method getAId()
  location: variable bDTO of type com.mycompany.myapp.service.dto.BDTO

Related issues

Suggest a Fix

JHipster Version(s)

6.4.1

JHipster configuration

See JDL above

Entity configuration(s) entityName.json files generated in the .jhipster directory

Browsers and Operating System

Windows 10

• [X] Checking this box is mandatory (this is just to show you read everything)

[MathieuAA]

The obvious fix is to release a new version, which I will do very very very soon. Like before the end of the week (hopefully)

[MathieuAA]

But this is blocking :( I'll release ASAP and do the necessary PR

[murdos]

@MathieuAA Are you sure your last comments apply to this issue, and not the other one: #10739 ?

[MathieuAA]

This one. The other one isn't blocking.

[MathieuAA]

@murdos I'm mixing comments, agrred ;) but the fix is the same. I'll do my best to close them before v6.5.0

[murdos]

I've tested the above JDL with JHipster v6.5.0 and I still have the issue.

[MathieuAA]

Ah, that's weird. I'll figure it out.

[pmverma]

Actually this is not related to jhipster-core but this is how it will generate when the entity name is a single character.

While you are expecting like a java bean setter/getter naming,

    public Long getBId() {
        return bId;
    }

but in actual, it generates by applying .toLowerCase()

    public Long getbId() {
        return bId;
    }

You can check at https://github.com/jhipster/generator-jhipster/blob/56a5d39cb086ed823af3bf1c7479e766da0f740f/generators/entity-server/templates/src/main/java/package/service/dto/EntityDTO.java.ejs#L211-L214

I don't get the reason behind it but there will be some good one to do lowercases.

[MathieuAA]

I wish github had the :clap: reaction to comment in issues.

[ruddell]

Possibly related to the comment here: https://github.com/jhipster/generator-jhipster/issues/2899#issuecomment-200603494

[pmverma]

One simple possible thing is to do not allow a single character entity name.
While technically possible to use it but it has no real meaning in real projects.

[pascalgrimaud]

I don't think it's related to single caracter
I tried this issue in v6.5.0 with similar JDL, replacing entities by a longer name and it failed too

[pmverma]

@pascalgrimaud I am saying specifically for the below-mentioned error.

[ERROR] src/main/java/com/mycompany/myapp/web/rest/AResource.java:[55,32] cannot find symbol
  symbol:   method getBId()
  location: variable aDTO of type com.mycompany.myapp.service.dto.ADTO
[ERROR] src/main/java/com/mycompany/myapp/service/AService.java:[49,24] cannot find symbol symbol:   method getBId()
  location: variable aDTO of type com.mycompany.myapp.service.dto.ADTO
[ERROR] src/main/java/com/mycompany/myapp/service/dto/ADTO.java:[56,22] cannot find symbol
  symbol:   method getBId()
  location: class com.mycompany.myapp.service.dto.ADTO
[ERROR] src/main/java/com/mycompany/myapp/service/BService.java:[50,24] cannot find symbol
  symbol:   method getAId()
  location: variable bDTO of type com.mycompany.myapp.service.dto.BDTO
[ERROR] src/main/java/com/mycompany/myapp/web/rest/BResource.java:[56,32] cannot find symbol
  symbol:   method getAId()
  location: variable bDTO of type com.mycompany.myapp.service.dto.BDTO

There we assume getBId() but in actual it is getbId().

[MathieuAA]

@pascalgrimaud did you? I remember seeing it working when we were trying to find the relationship-fetching issue.

[MathieuAA]

I'll try again, maybe my test wasn't good enough

[MathieuAA]

Ah you're right :) I wonder if it's related to the JDL though. I'll try without a JDL file

[MathieuAA]

I think I got it... confirming

[MathieuAA]

Okay, I'm fixing it and releasing it in a few minutes. The issue is the useJpa in both entities (in the JSON files)

[MathieuAA]

This should be good now by the way (completely forgot about this issue, sorry)

[pascalgrimaud]

@MathieuAA @murdos : what is the state of this issue ? Is it fixed or not yet ?

[MathieuAA]

Fixed on my end.

[pascalgrimaud]

ok then, let's close this.
@murdos: don't hesitate to reopen if it's not the case