Generator-jhipster: Do we need JhiLanguageController?

[marcelinobadin]

Everywhere in the front-end code where we use this controller can be easily moved to use only the JhiLanguageService. The only change on the service is to add a changeLanguage method.

Also, it will simplify, because everywhere we have to use the controller we need to inject dependencies that already contained on the service.

On my humble opinion, we can remove the controller and keep only the service, filter and constants.

[wmarques]

Agree with you, on top of that, we should avoid to use the ng-controller and keep controller assignments in routes.
So it seems logic to me to remove the LanguageController and put logic in the service.

[deepu105]

yes it can be removed. may be lets do it for ng2 directly

Thanks & Regards,
Deepu

On Thu, Jul 7, 2016 at 9:23 PM, William Marques [email protected]
wrote:

Agree with you, on top of that, we should avoid to use the ng-controller
and keep controller assignments in routes.
So it seems logic to me to remove the LanguageController and put logic in
the service.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jhipster/generator-jhipster/issues/3807#issuecomment-231076025,
or mute the thread
https://github.com/notifications/unsubscribe/ABDlF0ThGYNYb-YxotD6PMwdVC6MkZl5ks5qTP3vgaJpZM4JG7m_
.

[deepu105]

Im closing this as we agree that this will be removed for ng2