Generator-jhipster: Upgrade Spring-boot to 2.1.x

Created on 30 Jul 2018  Â·  19Comments  Â·  Source: jhipster/generator-jhipster

Overview of the feature request

With the launch of new spring-boot 2.1.0.M1 I would like that we create a branch to prepare the migration.


See: https://spring.io/blog/2018/07/30/spring-boot-2-1-m1

Motivation for or Use Case


Stay in line with Spring-boot releases

Related issues or PR
  • [x] Checking this box is mandatory (this is just to show you read everything)

All 19 comments

AFAIK, Spring Boot 2.1 won’t be released until Feb 2019, so it might be a bit early.

On Jul 30, 2018, at 17:00, Daniel Franco notifications@github.com wrote:

Overview of the feature request

With the launch of new spring-boot 2.1.0.M1 I would like that we create a branch to prepare the migration.

See: https://spring.io/blog/2018/07/30/spring-boot-2-1-m1

Motivation for or Use Case

Stay in line with Spring-boot releases

Related issues or PR

Checking this box is mandatory (this is just to show you read everything)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@mraible

From Github milestones I see: https://github.com/spring-projects/spring-boot/milestones

  • 2.1.0.M2: Aug 21
  • 2.1.0.RC1: Sep 20

I was expecting that we could launch first Beta version based on 2.1.0.RC1 at least?

I don't think we will do betas with RC releases unless there is a killer feature or something in it, so I agree with @mraible that its too soon and we have a lot on our plates already.
WDYT @jdubois

closing this for now, we can start work once we are ready to upgrade

@jdubois Will you consider to start soon a branch to migration to spring-boot 2.1.x?

Is that such a big change that we need a specific branch? If it's simple, a PR would be enough

After that we could then think in migrating to micrometer...

@jdubois To proceed with the PR I created my own branch https://github.com/DanielFran/jhipster/tree/spring-boot-2.1.0

Already identified an issue with JCache: see https://github.com/jhipster/generator-jhipster/issues/7783

And we have to test Cassandra too

@sendilkumarn, it is in my todo list as soon as I have jhipster compiling... But I need to get ride of Jcache changes first.

And it is needed also to test couchbase...

@jdubois I created this PR https://github.com/jhipster/jhipster/pull/88, but we have some impacts in this project.

Can you please help how I can now proceed with those changes for generator without a branch?
Could it be possible that you create a snapshot of jhispter-dependencies? Other suggestion?

It is needed update dependencies in this project and test that couchbase/cassandra is working.

Then this PR https://github.com/jhipster/generator-jhipster/pull/8019 can proceed with the missing changes.

Thanks

Here is how I work:

  • I do snapshots of jhipster/jhipster locally using mvn install
  • I reference those snapshots in jhipster/generator-jhipster so my projects use it

And when I need to test "for real" I also deploy those snapshots to https://jhipster.jfrog.io/jhipster (but that's more complex, let's not do this right now). So if you can just test locally -> I'll then merge your PR in jhipster/jhipster and publish a new release on Maven Central, so then you'll be able to use it.

@DanielFran migrating towards Micrometer (#7100) is something that can already be initiated ahead? (using 2.0.x )

@tubbynl no, work on Micrometer hasn't started yet. This would be huge, I don't expect it to be done soon - next time I have trainee, this could be is task for 6 months.

yes, i can imagine that it also impacts al lot, unfortunately i also don't have that kind of resources available

@jdubois @deepu105 @mraible @sendilkumarn Spring updated dates for next 2.1.x milestones:

  • 2.1.0.M3: Due by September 12, 2018
  • 2.1.0.M4: Due by September 24, 2018
  • 2.1.0.RC1: Due by October 15, 2018
  • 2.1.0: Due by October 29, 2018

https://github.com/spring-projects/spring-boot/milestones

Was this page helpful?
0 / 5 - 0 ratings

Related issues

dronavallisaikrishna picture dronavallisaikrishna  Â·  3Comments

kaidohallik picture kaidohallik  Â·  3Comments

DanielFran picture DanielFran  Â·  3Comments

tomj0101 picture tomj0101  Â·  3Comments

marcelinobadin picture marcelinobadin  Â·  3Comments