Generator-jhipster: Sample apps not updated

Created on 9 Dec 2017  Â·  10Comments  Â·  Source: jhipster/generator-jhipster

By request of @jdubois , I open this ticket because some sample applications like jhipsterSampleMicroservice are not updated since Jul-19…!

Most helpful comment

Consider it done. I'll also update all our samples, and add a React sample.

All 10 comments

I will do this

Thanks @DanielFran

Consider it done. I'll also update all our samples, and add a React sample.

@jdubois : I wonder if all samples should migrate :

  • from Angular1 to AngularX
  • from session to JWT

You already did it for https://github.com/jhipster/jhipster-sample-app/

I can PR if you're OK

Yes @pascalgrimaud we should have AngularX everywhere (well, not for ng1 and react samples, of course), but I guess it's already mostly the case.
For security, JWT makes indeed much more sense, as this is what most people use.

Ok, so I will do PR
Don't forget to git pull once all PR are merged, otherwise, you will have conflicts when you want to update all samples

Wrong @ mention

p📱

On Dec 11, 2017 11:16 PM, "Pascal Grimaud" notifications@github.com wrote:

@dubois https://github.com/dubois : I wonder if all samples should
migrate :

  • from Angular1 to AngularX
  • from session to JWT

You already did it for https://github.com/jhipster/jhipster-sample-app/

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jhipster/generator-jhipster/issues/6837#issuecomment-350965352,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAI1MEFUH5z4l7FmBcLVAWz-P8AjrOg3ks5s_ig2gaJpZM4Q8KR-
.

yes, sorry, I was on my phone :-p

Sorry @Dubois !! I didn't know about Tilt Brush that looks awesome!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

SudharakaP picture SudharakaP  Â·  3Comments

pascalgrimaud picture pascalgrimaud  Â·  3Comments

chegola picture chegola  Â·  4Comments

kaidohallik picture kaidohallik  Â·  3Comments

dronavallisaikrishna picture dronavallisaikrishna  Â·  3Comments