Gdevelop: Piskel Editor has no close option 5.0.0-beta58

[Baylissimo]

Describe the bug

In the latest release of GDevelop (5.0.0-beta58) on MacOS there is no option to close the Piskel editor. On Windows you can go through Piskel options and save then close the window, but there is no way to close the editor on MacOS.

[4ian]

There are Save and Cancel button on the top right, right?

[Baylissimo]

I've updated both on my Mac and PC and those buttons aren't appearing any
more.

On Tue, 11 Dec 2018 at 21:15, Florian Rival [e-mail]
wrote:

There are Save and Cancel button on the top right, right?

[image: image]
https://user-images.githubusercontent.com/1280130/49793641-9e8a0080-fd2d-11e8-805a-ad7fc2d833ab.png

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/4ian/GDevelop/issues/792#issuecomment-446147168, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AOoZIGUoRnRMHrW9_EHgudy1O6-8vCigks5u34WrgaJpZM4ZNEVe
.

[4ian]

Can you poste a screenshot for me to see the interface?

[4ian]

Was able to reproduce, it's happening indeed but not during development. Will take a look. For now, better downgrade to the previous beta.
Thanks for reporting it! I will disable download for the new beta.

[Baylissimo]

[image: Screen Shot 2018-12-11 at 9.22.12 pm.png]
This is from Mac Mojave

On Tue, 11 Dec 2018 at 21:19, Florian Rival [e-mail]
wrote:

Can you poste a screenshot for me to see the interface?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/4ian/GDevelop/issues/792#issuecomment-446148695, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AOoZICD6JaGjbi-RhwGl8RyUlxEyrdU6ks5u34bOgaJpZM4ZNEVe
.

[Baylissimo]

No worries.
Can I ask here, is the only way to downgrade to unistall and reinstall with
previous installer?

On Tue, 11 Dec 2018 at 21:23, Florian Rival [e-mail]
wrote:

Was able to reproduce, it's happening indeed but not during development.
Will take a look. For now, better downgrade to the previous beta.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/4ian/GDevelop/issues/792#issuecomment-446149798, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AOoZIPBhFLV0-m-MeYFbzYSrUw9lbpO5ks5u34ePgaJpZM4ZNEVe
.

[4ian]

Yes you can entirely remove the current app and install with the previous installer.

[Baylissimo]

Cheers

On Tue, 11 Dec 2018 at 21:32, Florian Rival [e-mail]
wrote:

Yes you can entirely remove the current app and install with the previous
installer.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/4ian/GDevelop/issues/792#issuecomment-446152951, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AOoZIE9ZqXApSD-ljqJMe3NbvaI9FK_Cks5u34nHgaJpZM4ZNEVe
.

[blurymind]

Sorry I missed this. I don't have a way to test on Mac

On Tue, Dec 11, 2018, 10:34 AM Mikey Bayliss <[email protected]
wrote:

Cheers

On Tue, 11 Dec 2018 at 21:32, Florian Rival [e-mail]
wrote:

Yes you can entirely remove the current app and install with the previous
installer.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/4ian/GDevelop/issues/792#issuecomment-446152951,
or mute
the thread
<
https://github.com/notifications/unsubscribe-auth/AOoZIE9ZqXApSD-ljqJMe3NbvaI9FK_Cks5u34nHgaJpZM4ZNEVe

.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/4ian/GDevelop/issues/792#issuecomment-446153710, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AGMbVVJ6cxTL0dYD0SC3qifTVNYqr0H8ks5u34pPgaJpZM4ZNEVe
.

[4ian]

@blurymind The issue is not specific to Mac, the buttons and the folder/filename are not showing at all after building GDevelop it seems

[Baylissimo]

1 minute ago
Details
I can't see the buttons on the PC either.

But I can close the window.

On Tuesday, December 11, 2018, Todor Imreorov [e-mail]
wrote:

Sorry I missed this. I don't have a way to test on Mac

On Tue, Dec 11, 2018, 10:34 AM Mikey Bayliss <[email protected]
wrote:

Cheers

On Tue, 11 Dec 2018 at 21:32, Florian Rival [e-mail]
wrote:

Yes you can entirely remove the current app and install with the
previous
installer.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/4ian/GDevelop/issues/792#issuecomment-446152951,
or mute
the thread
<
https://github.com/notifications/unsubscribe-auth/AOoZIE9ZqXApSD-
ljqJMe3NbvaI9FK_Cks5u34nHgaJpZM4ZNEVe

.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/4ian/GDevelop/issues/792#issuecomment-446153710,
or mute
the thread
AGMbVVJ6cxTL0dYD0SC3qifTVNYqr0H8ks5u34pPgaJpZM4ZNEVe>
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/4ian/GDevelop/issues/792#issuecomment-446171638, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AOoZIEojiRUTfq_WtpCfgmlvo7X28R5tks5u35iZgaJpZM4ZNEVe
.

[blurymind]

Ok, I will try to fix it later today. Apologies for the inconvenience

On Tue, Dec 11, 2018, 11:44 AM Mikey Bayliss <[email protected]
wrote:

1 minute ago
Details
I can't see the buttons on the PC either.

But I can close the window.

On Tuesday, December 11, 2018, Todor Imreorov [e-mail]
wrote:

Sorry I missed this. I don't have a way to test on Mac

On Tue, Dec 11, 2018, 10:34 AM Mikey Bayliss <[email protected]
wrote:

Cheers

On Tue, 11 Dec 2018 at 21:32, Florian Rival [e-mail]
wrote:

Yes you can entirely remove the current app and install with the
previous
installer.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/4ian/GDevelop/issues/792#issuecomment-446152951
,
or mute
the thread
<
https://github.com/notifications/unsubscribe-auth/AOoZIE9ZqXApSD-
ljqJMe3NbvaI9FK_Cks5u34nHgaJpZM4ZNEVe

.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/4ian/GDevelop/issues/792#issuecomment-446153710,
or mute
the thread
AGMbVVJ6cxTL0dYD0SC3qifTVNYqr0H8ks5u34pPgaJpZM4ZNEVe>
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/4ian/GDevelop/issues/792#issuecomment-446171638,
or mute
the thread
<
https://github.com/notifications/unsubscribe-auth/AOoZIEojiRUTfq_WtpCfgmlvo7X28R5tks5u35iZgaJpZM4ZNEVe

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/4ian/GDevelop/issues/792#issuecomment-446173845, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AGMbVYt97f-HGHmoqosG3GhxtQtZ6WMSks5u35qIgaJpZM4ZNEVe
.

[blurymind]

@4ian I reverted it to the old initialization approach. Will test tonight and submit a fix 👍

Sorry again for the inconvenience. Not sure why its working on the development version but not on the builds, I should have tested it better

[blurymind]

@4ian it looks like the electron version of the build refuses to execute setInterval. I am currently trying to find a workaround.

I tried this:
https://github.com/electron/electron/issues/7079#issuecomment-325706135
without much luck

[4ian]

Is setInterval not launched at all? If so, could we use setTimeout to emulate it? (you set a timeout, then in the timeout function, if pskl is still null, you set a new timeout for the same function)

If really need, we can also resort to using requestAnimationFrame (which is like a timeout/interval which is as quick as possible).

[blurymind]

@4ian I figured it out, then slapped myself on the forehead.
It's in the html index file - the way I load the module is not using your new method- gdide.
Nothing in the js file was called on the build version as a result.

I think this is it - testing now and will submit a fix.

[blurymind]

@4ian pull here:
https://github.com/4ian/GDevelop/pull/795
I made the init procedure of piskel more similar to the one that jfxr uses

Sorry it took me ages- rebuilding and testing is really slow when a bug it only in builds

[4ian]

Good catch - I totally missed that during the review

[4ian]

Published beta59 with the fix! Thanks for your quick fix! Appreciate it :)

[Baylissimo]

You guys are awesome. Thanks again for Gdevelop.

On Wednesday, December 12, 2018, Florian Rival [e-mail]
wrote:

Published beta59 with the fix! Thanks for your quick fix! Appreciate it :)

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/4ian/GDevelop/issues/792#issuecomment-446372628, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AOoZIMsm39kNYLwl6BLDZOQSdjRPhg6cks5u4CZ4gaJpZM4ZNEVe
.

[blurymind]

Can you guys test and confirm the fix works for you as well?

On Tue, Dec 11, 2018, 9:58 PM Mikey Bayliss <[email protected] wrote:

You guys are awesome. Thanks again for Gdevelop.

On Wednesday, December 12, 2018, Florian Rival [e-mail]
wrote:

Published beta59 with the fix! Thanks for your quick fix! Appreciate it
:)

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/4ian/GDevelop/issues/792#issuecomment-446372628,
or mute
the thread
<
https://github.com/notifications/unsubscribe-auth/AOoZIMsm39kNYLwl6BLDZOQSdjRPhg6cks5u4CZ4gaJpZM4ZNEVe

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/4ian/GDevelop/issues/792#issuecomment-446378213, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AGMbVS2MjCGiH6kXkE9DNZvAWVy0Nhz6ks5u4CqdgaJpZM4ZNEVe
.

[Baylissimo]

Works on both Mac and PC for me.
And the layers and locate buttons work well too.

Cheers

On Wed, 12 Dec 2018 at 09:14, Todor Imreorov [e-mail]
wrote:

Can you guys test and confirm the fix works for you as well?

On Tue, Dec 11, 2018, 9:58 PM Mikey Bayliss <[email protected]
wrote:

You guys are awesome. Thanks again for Gdevelop.

On Wednesday, December 12, 2018, Florian Rival <[email protected]

wrote:

Published beta59 with the fix! Thanks for your quick fix! Appreciate it
:)

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/4ian/GDevelop/issues/792#issuecomment-446372628,
or mute
the thread
<

https://github.com/notifications/unsubscribe-auth/AOoZIMsm39kNYLwl6BLDZOQSdjRPhg6cks5u4CZ4gaJpZM4ZNEVe
>

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/4ian/GDevelop/issues/792#issuecomment-446378213,
or mute
the thread
<
https://github.com/notifications/unsubscribe-auth/AGMbVS2MjCGiH6kXkE9DNZvAWVy0Nhz6ks5u4CqdgaJpZM4ZNEVe

.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/4ian/GDevelop/issues/792#issuecomment-446382977, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AOoZIHIuPerC9_27XCj1k-ZgpZAYDUU5ks5u4C5VgaJpZM4ZNEVe
.

[blurymind]

Glad to hear that! Thank you for submitting the bug report. Really happy that we caught it early after release