Gatsby: Protect master branch

Created on 15 Oct 2019  路  2Comments  路  Source: gatsbyjs/gatsby

Description

We are working on Russian translation in https://github.com/gatsbyjs/gatsby-ru repo, and in some reason a few not native speakers sending to us PR with robotic translation of docs (Google Translator or something else):

https://github.com/gatsbyjs/gatsby-ru/pull/7
https://github.com/gatsbyjs/gatsby-ru/pull/17

We are still not sure why they are doing that (maybe for a swag 馃), but we had a real problem with second case. Developer committed directly to master without any approval https://github.com/gatsbyjs/gatsby-ru/commit/b6301dce6f229a9e71a8000b8eaa177d37a0c81c, then he is asked to revert it, but it's still a problem.

Expected result

master branch should be protected from direct commits and allow only PR approach.

Actual result

Everyone, with member rights able to commit directly to master.

i18n documentation question or discussion

All 2 comments

Thanks for pointing this out @alexandrtovmach. The gatsby-es and gatsby-ru repos now have branch protection and require a CODEOWNERS code review before merging PRs.

@m-allanson Thank you

Was this page helpful?
0 / 5 - 0 ratings

Related issues

andykais picture andykais  路  3Comments

jimfilippou picture jimfilippou  路  3Comments

benstr picture benstr  路  3Comments

dustinhorton picture dustinhorton  路  3Comments

brandonmp picture brandonmp  路  3Comments