Gatsby: chore(gatsby-source-filesystem): Deprecate multiple different versions of birth time on File

Created on 1 Jul 2019  路  5Comments  路  Source: gatsbyjs/gatsby

@pieh and I noticed that we have three different versions of birth time in File

  • birthTime
  • birthtime
  • birthtimeMs

Probably want to clean this up at some point 馃槀

good first issue help wanted
Source
picture sidharthachatterjee

Most helpful comment

No one noticed before @pieh went and added that explorer sidebar!!! 馃槄

picture KyleAMathews on 1 Jul 2019
😄2

All 5 comments

What's the work involved in this @sidharthachatterjee?

spences10 picture spences10 on 1 Jul 2019

No one noticed before @pieh went and added that explorer sidebar!!! 馃槄

KyleAMathews picture KyleAMathews on 1 Jul 2019
😄2

@spences10 We'll probably want to

  • mark two of them (birthtime and birthtimeMs likely) as deprecated in GraphQL and show a warning when they are used
  • update usage across this repo to birthTime
sidharthachatterjee picture sidharthachatterjee on 2 Jul 2019

Hey there! I took a look at this and I decided to follow what @sidharthachatterjee mentioned.
I searched for usages of birthtime and birthtimeMs in the codebase but I only found them in types declarations files, so I've updated them too.

Simonpedro picture Simonpedro on 4 Jul 2019
👍1

We still have those on version 2.1.0

henricazottes picture henricazottes on 24 Jun 2020
Was this page helpful?
0 / 5 - 0 ratings

Related issues

dustinhorton picture dustinhorton  路  3Comments
kalinchernev picture kalinchernev  路  3Comments
totsteps picture totsteps  路  3Comments
dustinhorton picture dustinhorton  路  3Comments
benstr picture benstr  路  3Comments