Fsnotes: Inline tagging system picking up extraneous data

[koyedele]

Describe the bug
I have Ruby code enclosed in code tags but because I have #{one} within a String in the Ruby code, a new tag is created for {one}. Is it possible to not scan code samples for tags?

To Reproduce
Steps to reproduce the behavior:

1. Create a new note
2. Create a code block using three backticks and specify the language as Ruby, for example

watermelon = 'code'
"Here's some ruby #{watermelon}"

1. Notice that a new tag with name {watermelon} is created

Expected behavior
Scanning for inline tags should respect some boundaries for Markdown text especially code samples that are clearly defined

Actual behavior
Scanning for inline tags does not respect code boundaries so a lot of useless tags get created

Workaround
Disable scanning for inline tags

Supporting Files

Desktop (please complete the following information):

• OS: macOS
• OS version: 10.14.6
• FSNotes version: 4.0.2

Additional context

[glushchenko]

You can add #notags tag for disable tags

[koyedele]

Thanks for the quick turnaround! If I do that, I do not get tags at all. I do want to be able to tag notes, but I also want to be able to have code samples in there. It seems that the scanning of inline tags doesn't support both.

[glushchenko]

You proposal is code blocks checking in tags scanner?

[koyedele]

I would say yes.

`This #{var} should not become a tag`

and

This #{var} should not become a tag either

Apparently, it affects Latex blocks as well. So

$ a \dot b #some_random_thing $

should not become a tag and

$$
This #var should not show up as a tag either
$$

I notice that it seems FSNotes doesn't support <pre> blocks. On GitHub, if I want to write the literal three back-tick characters without starting a code block (like I've been doing in this issue post), I can surround the text with <pre></pre> and it will come out unmodified. The point is, if FSNotes ever starts supporting that or if it supports some other way, then we'd need to make sure that we don't search those fenced blocks for tags as well.

[isao]

Hi @glushchenko great app, thanks for your work.

I just filed #733 which I just realized is somewhat a dupe of this bug.

My suggestion there is to treat a valid tag as a # followed by at least one letter, preferably something like this regex: /#[a-zA-Z][a-zA-Z0-9\-]+/

Right now I have tons of accidental tags for my imported notes. In my case I have many notes which contain misc log output statements, bash, or ruby...

[Aetles]

Yeah, I have a lot of notes with hex colors (like #FF0000) and I would prefer if they were not picked up.

[glushchenko]

Numbers and hex will be excluded from 4.0.7, code blocks I think a little bit later.

[GeoJunkie]

I'm afraid I might add another level of complexity, but I'll ask anyway. I use Slack extensively and many of my notes refer to Slack channels, which all start with a # (e.g. the main #announcements channel).

Would it be possible to have a "not a tag" option to exclude specific strings from being marked as tags?

[glushchenko]

Add #notags in note