Fsharpplus: RC4 - DList isn't fully Fable compatible

Created on 3 Apr 2020  路  9Comments  路  Source: fsprojects/FSharpPlus

Fable isn't able to type test generic arguments, so this line when compiled via Fable gives a warning that it isn't valid.

Most helpful comment

I have no idea which would be optimal to be honest, that's why I figured I'd leave the implementation to you 馃槄

All 9 comments

Yes, I saw that.

But I am not sure how typically you define equality in Fable. Do you know how?

I've always just worked around it in the past, I played around in the repl for a while with no success. I'm not sure if it's possible for this type of scenario?

Maybe @MangelMaxime or @ncave could chime in about it.

@Shmew See if anything here helps: https://github.com/fable-compiler/Fable/issues/1981

@gusty did ncave's link help?

Looks helpful, tbh I still have to study all the possibilities.
Do you have a specific suggestion?

I have no idea which would be optimal to be honest, that's why I figured I'd leave the implementation to you 馃槄

Well, perhaps we could pair program it?

@Shmew I read all the options but none of them seem to address our issue.

I did a forced cast for Fable, which in theory would throw exceptions but AFAIK the type checking process would prevent from comparing 2 different types.

Have a look at the PR #314

Sorry I haven't been able to reply sooner! I've been pretty busy. It looks fine to me, if the tests pass then 馃憤.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

cmeeren picture cmeeren  路  5Comments

DunetsNM picture DunetsNM  路  9Comments

Shmew picture Shmew  路  5Comments

btrepp picture btrepp  路  3Comments

TOTBWF picture TOTBWF  路  7Comments