Fsharpplus: RC version missing files for Fable

Created on 15 Mar 2020  路  5Comments  路  Source: fsprojects/FSharpPlus

in the latest stable release there are no directories in the fsproj. With the changes to putting files into directories, the fsproj needs to be updated so that Fable can properly compile the project.

Currently this is the output when trying to build the project:
image

Which results in:
image

The fix should be pretty simple, just expand the fsproj to be:

  <!-- Add source files to "fable" folder in Nuget package - required for the library to be consumable by Fable -->
  <ItemGroup>
    <Content Include="*.fsproj; *.fs" PackagePath="fable/" />
    <Content Include="Extensions/*.fs" PackagePath="fable/FSharpPlus/Extensions" />
    <Content Include="Control/*.fs" PackagePath="fable/FSharpPlus/Control" />
    <Content Include="Math/*.fs" PackagePath="fable/FSharpPlus/Math" />
    <Content Include="Data/*.fs" PackagePath="fable/FSharpPlus/Data" />
  </ItemGroup>
bug

Most helpful comment

@gusty it is indeed working now!

All 5 comments

Perhaps you'd want to make a small PR to fix it @Shmew ?

I wonder how can we prevent this to happen with our Fable CI / tests?

Disregard my original comment if you already saw that.

All you need to do for that is to do globbing on the directory to get all the *.fsproj and *.fs files and then open up the nupkg and compare that vs the fable directory that gets created.

@Shmew RC4 is published
It would be great if you could give it a try and let us know how it goes.

@gusty it is indeed working now!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

abelbraaksma picture abelbraaksma  路  3Comments

gusty picture gusty  路  7Comments

cmeeren picture cmeeren  路  5Comments

Shmew picture Shmew  路  9Comments

aammfe picture aammfe  路  10Comments