Frontend: Automations condition.weekday missing in Automation GUI
The weekday interface in the Automations UI is missing.
I have the following config:
- id: '1555796295451'
alias: Verwarming uit MA DI WO DO
trigger:
- at: '11:30'
platform: time
condition:
- condition: time
weekday:
- mon
- tue
- wed
- thu
action:
- data:
entity_id: climate.woonkamer,climate.serre
temperature: 16
service: climate.set_temperature
- data:
entity_id: automation.schuifpui_dicht_zet_verwarming_aan
service: automation.turn_off
But the interface looks like this
It would be nice to have a
ghost
All 10 comments
Currently, I have something like this (WIP):
TimeCondition interface has two fields: after and before, I've added the third field that holds weekdays, but while working on this I get a feeling that we shouldn't mix time and weekday in a single condition.
I think that weekday should be added as a separate condition type:
I'm aware that weekday is part of the time condition (https://www.home-assistant.io/docs/scripts/conditions/#time-condition), but you can add two conditions for time and for weekday with AND condition.
I propose to split that condition into two:
@bramkragten @iantrich do you think?
Not sure what changes need to be added to the front and to the backend, but before I do anything I'd like to discuss this.
The easiest thing to do would be to replace time condition (that contains weekday) with two conditions inside AND condition.
So instead of:
you would get:
Misiu
on 9 Mar 2020
I think the split is a good idea UX wise, but I think it is good idea to keep the frontend and backend/yaml aligned and that would be breaking... Can you create an architecture issue for this?
bramkragten
on 9 Mar 2020
@bramkragten created: https://github.com/home-assistant/architecture/issues/356
Could you please add an upvote for it? :)
Misiu
on 9 Mar 2020
@bramkragten I've added https://github.com/home-assistant/frontend/pull/5324.
It's my first PR that requires frontend, backend, docs and architecture changes.
I'm not sure about breaking changes policy, but for now, I left weekday property in time condition, this will be removed in 0.109, or future release if change requested.
Misiu
on 23 Mar 2020
@bramkragten what do you think about this?
I got some feedback on https://github.com/home-assistant/architecture/issues/356 by @MartinHjelmare and I'm not sure if this will get approved.
As I wrote before I can add weekdays to current condition editor, but I think it should be split into smaller editors (time and weekday condition).
Can I ask for your opinion?
Misiu
on 20 Apr 2020
@Misiu Can these be faked? As in, the UI shows the conditions as weekday or time but really the yaml is written how it is now?
zsarnett
on 28 Apr 2020
@Misiu Martin is right there, we can already do what you want without a backend change.
bramkragten
on 2 May 2020
I'd like to get back to this.
I can put the weekday condition part in accordion, for example, vaadin-accordion.
This will look like this (don't look at style):
But as mentioned before my main motivation was to split weekday and time into two separate conditions.
If you have automation that needs to run three times a day on specific days you can add one condition for days and a second (a group with or) for hours. This will take less space than 3 large conditions showing time and days.
There is one bonus: If you want to disable automation for a specific day you will only edit it in one place.
@zsarnett as @bramkragten wrote here we should align frontend and backend.
I'm not a UX designer and I don't have idea what would be the best design for this editor.
WDYT about the accordion approach? By default, it would be collapsed, but when at least one day is selected I can expand it.
Misiu
on 20 Jul 2020
@bramkragten another prototype:https://stackblitz.com/edit/ha-expand-panel?file=index.html
I've created ha-expand-panel component.
Idea is to expand Weekday's condition when there is at least one day selected.
Not sure how to handle hours, but if the inputs will be empty then I can collapse that section too.
I'm using mwc-formfield because this allows clicking on label to change switch value.
I'd also would like to use ha-textfield component instead of paper-input because we can set type (time in this case).
Misiu
on 27 Aug 2020
@Misiu I think this looks nice!
emontnemery
on 27 Aug 2020
Related issues
martinhoess
路
3Comments
Fusseldieb
路
4Comments
Misiu
路
3Comments
andriej
路
3Comments
casperklein
路
4Comments
Most helpful comment
I think the split is a good idea UX wise, but I think it is good idea to keep the frontend and backend/yaml aligned and that would be breaking... Can you create an architecture issue for this?