Freshrss: Can't use arrow keys as shortcuts after update to 1.14.0

Created on 1 Apr 2019  路  6Comments  路  Source: FreshRSS/FreshRSS

Since the last update I'm unable to use the "left" and "right" arrow keys for browsing articles. I have set "Open the next article" to "right" and "Open the previous article" to "left" in the shortcut menu. This did work in the previous version. Other shortcuts for browsing do seem to work (tested "R"-key and "L"-key).

UI

All 6 comments

The keyword left was specific to the old shortcut plugin. I suspect ArrowLeft would work, but the PHP side of things currently rejects that.

https://github.com/FreshRSS/FreshRSS/blob/d413f67dd28738f4a6d8cf036e00714737f757b8/app/Controllers/configureController.php#L156-L175

@Alkarex Shall we add the old values to the JS or change the PHP to standard JS?

Yes, let's change the PHP code to use the standard codes such as ArrowDown, and possibly add a conversion in PHP for old configurations.

Incidentally, the standard names are defined here: https://www.w3.org/TR/uievents-key/

But it's easier to get them from a quick event catcher, e.g., here.

PageUp and PageDown also stand out as being different.

Merged in the /dev branch to ease testing

Merged in the /dev branch to ease testing

Thanks for the quick fix! I can confirm the arrow keys are working again for browsing on /dev.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Sp3r4z picture Sp3r4z  路  4Comments

javerous picture javerous  路  5Comments

cwldev picture cwldev  路  5Comments

Stegemueller picture Stegemueller  路  3Comments

eminphi picture eminphi  路  5Comments