Freecodecamp: Donation Implementation Enhancements

Created on 16 Mar 2020 · 3Comments · Source: freeCodeCamp/freeCodeCamp

General:

[x] Get the button and the text labels for the donate amounts in the modal from config.
[x] Get the button and the text labels for the donate amounts in the certificates from config.
[x] Unify donation forms and make them atomic
[ ] Unify component state for Paypal and Stripe (overlap processing message when displaying)
[ ] Add Guidestar and SSL secure images to the button of donation forms
[ ] Add cypress tests for modal donation page
[x] Add GA to all donation related buttons and views

PayPal:

[x] Implement PayPal for one-time donations.
[ ] The logging needs to be improved to fix errors: https://github.com/freeCodeCamp/freeCodeCamp/pull/38239/files#r392905021
[ ] If a user is having a recurring donation before the rollout, we should handle those gracefully.
[ ] an identifier other than e mail should be added to the donations
[ ] resolve double rendering of paypal button
[ ] Make the donation and amount dynamic and audit records

Stripe:

[ ] Move to @stripe/stripe-js and @stripe/react-stripe-js
[ ] Implement Payment Request button.
[ ] Receive and react to web-hooks from stripe.

api client

Source

raisedadead

Most helpful comment

Can we add tabindex to the donation page as well? I can't tab through the form or the buttons available and that impacts accessibility. Thank you!

russsaidwords on 30 Jul 2020

👍2

All 3 comments

From the linked PR:

Well I think we should be hooking up something similar to rollbar for this. And the reply is lost by PayPal, I did not say a way that they log it.

I couldn't find much about this, just what Ahmad pointed out: that they try again 25 times over the next 3 days. That's if they either don't get a response or the response is not 200. So, I guess we trigger that if we think that if it's conceivable that something weird could happen causing a valid POST to fail when it hits /update-paypal and that subsequent POSTs could work.