Freecodecamp: Audit hardGoTo and unify if possible

Created on 3 Oct 2019  路  5Comments  路  Source: freeCodeCamp/freeCodeCamp

As pointed out in this comment and the ones below it. The hardGoTo code that is used in several places in the codebase is a "legacy thing that we had before we had navigate. It can be removed and cleaned up."

A search for "hardGoTo" reveals eight results. They can probably all be changed to use navigate and the redux file deleted.

api client
Source
picture moT01

Most helpful comment

In a perfect world I should be able to proxy everything, but sadly that would need a lot of re-write.

I am keeping this open for traceability.

picture raisedadead on 8 Oct 2019
👍2

All 5 comments

Hello, can I help on this one?

dsuarezlogans picture dsuarezlogans on 3 Oct 2019

go for it @dsuarezlogans

moT01 picture moT01 on 4 Oct 2019
👍1

I re-audited this and realised that the hardGoTo is used for direct calls to the api endpoints without proxying through internally.

We should leave it be for now.

raisedadead picture raisedadead on 8 Oct 2019

@raisedadead as it stands, some api calls go via hardGoTo and some via navigate. Is it worth leaving this open until we've decided which should be which? Or are you already happy that they're as they should be?

ojeytonwilliams picture ojeytonwilliams on 8 Oct 2019

In a perfect world I should be able to proxy everything, but sadly that would need a lot of re-write.

I am keeping this open for traceability.

raisedadead picture raisedadead on 8 Oct 2019
👍2
Was this page helpful?
0 / 5 - 0 ratings

Related issues

EthanDavis picture EthanDavis  路  3Comments
imhuyqn picture imhuyqn  路  3Comments
ROWn1ne picture ROWn1ne  路  3Comments
cmal picture cmal  路  3Comments
bagrounds picture bagrounds  路  3Comments