Freecodecamp: Favicons are missing

Created on 15 Feb 2019  路  11Comments  路  Source: freeCodeCamp/freeCodeCamp

The current master does not have any favicons.

The likely culprit is my configuration of gatsby-plugin-manifest

https://github.com/freeCodeCamp/freeCodeCamp/blob/5f228f9b441d3664a60a6bb6106017d6bd156930/client/gatsby-config.js#L136-L149

help wanted device specific resolveshipping critical path

All 11 comments

On the latest master favicons look good to me locally.

@Bouncey Which pages are you getting that on? I cannot find it on rocks a.t.m. maybe I'm looking at the wrong places

I cannot see them locally or on .rocks?

Maybe only on firefox? I can see them in chrome

Chrome will cache it. Or make an icon available from other equivalent resources defined in the manifest.

image

The actual icon is a 404.

We were porting over our assets to the fCC CDN. Could this be related to that?

I believe #35568 resolved this. Could someone please try to reproduce it.

I can confirm that this issue is reproducible on the currently deployed version of rocks

@thecodingaviator, rocks might be a little bit behind at the moment. Could you please try to reproduce it locally?

@ahmadabdolsaheb Sure can, will get back here soon

Issue tested locally. The issue is fixed on latest master. Would ship soon

Was this page helpful?
0 / 5 - 0 ratings

Related issues

trashtalka3000 picture trashtalka3000  路  3Comments

raisedadead picture raisedadead  路  3Comments

ar5had picture ar5had  路  3Comments

robwelan picture robwelan  路  3Comments

bagrounds picture bagrounds  路  3Comments