Freecodecamp: Minor grammar mistake in CSS Grid: Create Flexible Layouts Using auto-fill

Created on 8 Aug 2018  路  12Comments  路  Source: freeCodeCamp/freeCodeCamp

Describe your problem and - if possible - how to reproduce it

The first sentence says: "The repeat function comes with a option called auto-fill." The article "a" is incorrect. Should be "an option".

Add a Link to the page with the problem

https://learn.freecodecamp.org/responsive-web-design/css-grid/create-flexible-layouts-using-auto-fill

Tell us about your browser and operating system

  • Browser Name: Chromium
  • Browser Version: 68.0.3440.75
  • Operating System: Linux Mint 18.3 Sylvia

If possible, add a screenshot here

image

first timers only

All 12 comments

Thank you! The contributor's guide is quite long. Also, I guess Egghead's course about contributing to an open source project is worth watching. Hope it won't take much time :-)

@dicoderr Are you addressing this fix, or is it up for grabs?

@Ashera138 "up for grabs".

I am fixing the typo right now, is that ok?

@alpkoseoglu OK.

I'm struggling with git, so don't feel like you have to wait on me haha. @alpkoseoglu

I failed so bad and stop trying, I think you can do it ! @Ashera138

So from what I can tell (bear with me - I'm very new to this), is that the file that this grammar mistake is in (freeCodeCamp/node_modules/@freecodecamp/curriculum/dist/challenges/01-responsive-web-design/css-grid.json) is generated or added after running npm install in git. I can obviously just go in this file, edit the change, and save it, but here's the problem I'm seeing:

That css-grid.json file is not in my git repo (since it was added after running that command), and even if it was, if it's something that's generated, you would need to change whatever creates that file upstream. That's beyond me.

Please correct me if I'm wrong about anything. This is where I am stuck. :)

when you run npm install it will install all the things in the package.json file - included in this repos package.json file is this line - https://github.com/freeCodeCamp/freeCodeCamp/blob/staging/package.json#L49 - this (@freecodecamp/curriculum) is the freecodecamp package that holds all the information for the challenges and it gets created from this repo - https://github.com/freeCodeCamp/curriculum - so to fix the typo you need to change in that repository - there's also a link to the exact file and line in the comment I made earlier - hopefully this helps, feel free to ask any more questions

Oh I see, thanks for clarifying! I'll see what I can do.

Alright, pull request submitted. Let's see how I did. 馃憤 https://github.com/freeCodeCamp/curriculum/pull/233

Was this page helpful?
0 / 5 - 0 ratings

Related issues

MichaelLeeHobbs picture MichaelLeeHobbs  路  3Comments

ar5had picture ar5had  路  3Comments

raisedadead picture raisedadead  路  3Comments

jurijuri picture jurijuri  路  3Comments

kokushozero picture kokushozero  路  3Comments