Freecodecamp: Syntax highlighting in editor

[QuincyLarson]

Currently the beta code editor pane (light theme) doesn't have syntax highlighting.

[systimotic]

@QuincyLarson It looks like this was a conscious choice by Berkeley: https://github.com/freeCodeCamp/freeCodeCamp/pull/14707/commits/4a63126fa575661e2907ed9d8e1f629575356125
I could add it back in, but it would probably useful to learn why it was removed first. /cc @BerkeleyTrue

[BerkeleyTrue]

An unfortunate side effect of changing themes.

[QuincyLarson]

@systimotic Yes - please see if you can get the syntax highlighting to work in the light theme. Ideally, switching to dark mode would also switch the Codemirror theme back to the old dark theme. That's probably a separate issue, but since you're digging around in there, I thought I'd mention this.

[no-stack-dub-sack]

@QuincyLarson @systimotic I've just made a PR to fix this, but like @systimotic, I am unsure if there was some deeper reason for @BerkeleyTrue's original choice here, however it does seem like this is doable with no other noticeable side effects.

Though we are not in production with this, people are still using the beta site quite a bit, and this makes the overall experience quite a bit better, so I'm all for it unless there's something else going on here I'm unaware of. Thanks.

[BerkeleyTrue]

please see if you can get the syntax highlighting to work in the light theme

@no-stack-dub-sack monokai was removed in favor of a light theme.

[no-stack-dub-sack]

Here are some choices. Or, we could just keep the old theme which has nice vibrant colors, and just make the editor background white (and change unquoted strings to a different color).

Thoughts @raisedadead @BerkeleyTrue @QuincyLarson?

default

paraiso-light

base-16-llight

solarized-light

[BerkeleyTrue]

The default of Monokai with a white background will work for me. The others will cause the codemirror instance to stand out from the rest of the pane.

@QuincyLarson thoughts?

[raisedadead]

I am also in favor of default one, for light theme.

[texas2010]

I am fine with default

[BerkeleyTrue]

@texas2010 Awesome. Let's move with the default theme.

[QuincyLarson]

@texas2010 @raisedadead @no-stack-dub-sack I am also in favor of the default theme for light mode.

[no-stack-dub-sack]

Sounds good, I'll update the PR