Freecodecamp: Use Responsive Design with Bootstrap Fluid Containers. Issue with wrong link example.
Challenge Name
Use Responsive Design with Bootstrap Fluid Containers
Issue Description
There is a wrong link given as an example in challenge description:
<link rel="stylesheet" href="//maxcdn.bootstrapcdn.com/bootstrap/3.3.1/css/bootstrap.min.css"/>
The correct link should be without "/" after "min.css":
<link rel="stylesheet" href="//maxcdn.bootstrapcdn.com/bootstrap/3.3.1/css/bootstrap.min.css">
Browser Information
- Browser Name, Version: IE 11
- Operating System: Windows 7
- Mobile, Desktop, or Tablet: Desktop
Screenshot
RAYDENFilipp
All 11 comments
I think this is bikeshedding?
Using link tags as self closing is completely fine in HTML5.
Will leave others to comment and close, or proceed in case they think otherwise.
/cc @freeCodeCamp/moderators
raisedadead
on 22 Feb 2017
It's an interesting detail, and since both technically are valid - maybe we should show the cleaner way to use a link tag?
Greenheart
on 22 Feb 2017
@raisedadead The problem is that before opening the issue, I read the Bootstrap Blog, and there was a link that made me think of a mistake. Anyway, if it is not the mistake, they probably should place the comment in the frecodecamp lesson to clarify this for others who will see it as a problem in future. I think that would be useful.
RAYDENFilipp
on 23 Feb 2017
@Greenheart @RAYDENFilipp cool, we can add a note about this.
raisedadead
on 23 Feb 2017
I can take this up. Will a note like this be clear enough?
"Using either of both > or /> to close the link tag are acceptable."
AngShiYa
on 24 Feb 2017
@AngShiYa Fantastic! Seems easy to get the message.
RAYDENFilipp
on 24 Feb 2017
@AngShiYa Sure, please go ahead. Thanks.
raisedadead
on 24 Feb 2017
Should the above link also be updated to v3.3.7 considering that v3.3.7 is required and included in the seed code for these challenges? I only mention this to maintain uniform consistency.
cdrani
on 24 Feb 2017
Yup, thanks @cdrainxv.
@AngShiYa if your taking a crack at this, could you please update the link as well, as noted above?
raisedadead
on 24 Feb 2017
Sure :)
AngShiYa
on 24 Feb 2017
Thanks to everyone involved! This is the beauty of OSS collaboration at it's best! :smile:
Greenheart
on 24 Feb 2017
Related issues
kokushozero
路
3Comments
danielonodje
路
3Comments
ROWn1ne
路
3Comments
ar5had
路
3Comments
DaphnisM
路
3Comments
Most helpful comment
Should the above link also be updated to v3.3.7 considering that v3.3.7 is required and included in the seed code for these challenges? I only mention this to maintain uniform consistency.