Freecodecamp: iPhone frame doesn't disappear on narrow widths like it should

Created on 23 Jan 2017  路  7Comments  路  Source: freeCodeCamp/freeCodeCamp

Steps to reproduce:

  1. open any challenge with an HTML component
  2. reduce the viewport and scroll to the bottom of the page.
  3. The iPhone frame will still be there when it shouldn't be.
help wanted
Source
picture QuincyLarson

All 7 comments

Never mind. Was mistaken.

dhcodes picture dhcodes on 23 Jan 2017

Is this issue open to everyone? I would be interested in it.

nawazishali picture nawazishali on 23 Jan 2017
👍1

@nawazishali yes, go forth! Follow the contributing guidelines when submitting your PR. You can ask for help in the Contributors chat room on gitter if you have questions or run into errors.

dhcodes picture dhcodes on 23 Jan 2017

Great will start working on this by tomorrow.

nawazishali picture nawazishali on 23 Jan 2017

@nawazishali Awesome! Thanks for jumping on this.

QuincyLarson picture QuincyLarson on 24 Jan 2017
👍1

@QuincyLarson I am just trying to give back to the Community. You are my teacher Quincy & Thank You so much for making this awesome site for self learners.

I have a question about this issue, the question is if iPhone Frame gets removed then where the result will get displayed? Currently If frame is removed result shows on a blank white area. Is this how it should be?

nawazishali picture nawazishali on 24 Jan 2017

@nawazishali yep that is fine; as long as the results show; that's the important part.

dhcodes picture dhcodes on 24 Jan 2017
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

EthanDavis picture EthanDavis  路  3Comments
robwelan picture robwelan  路  3Comments
DaphnisM picture DaphnisM  路  3Comments
kokushozero picture kokushozero  路  3Comments
ar5had picture ar5had  路  3Comments