Freecodecamp: 1 isn't a prime number, because it's only divisible by itself.

Created on 3 Jun 2016 · 10Comments · Source: freeCodeCamp/freeCodeCamp

Challenge Name

Sum All Primes

Issue Description

It is not true that one is not a prime number because it's only divisible by itself. If one applies the definition of a prime number - a number only divisible by 1 and by itself - 1 would be prime, as it has been historically. It's not because that would be inconvenient.
I suggest to change this sentence to _By convention, 1 is not a prime number._

first timers only help wanted

Source

lincore81

👍1

Most helpful comment

@lincore81 thanks for the feedback. Although historically one being prime is true, there are also times in history where mathematicians listed one as prime.

Instead, I propose a simpler change:

A prime number is defined as a number greater than one and having only two divisors, one and itself. For example, 2 is a prime number because it's only divisible by one and two.

erictleung on 3 Jun 2016

👍3

All 10 comments

@lincore81 thanks for the feedback. Although historically one being prime is true, there are also times in history where mathematicians listed one as prime.

Instead, I propose a simpler change:

A prime number is defined as a number greater than one and having only two divisors, one and itself. For example, 2 is a prime number because it's only divisible by one and two.

erictleung on 3 Jun 2016

👍3

@erictleung Sure, that sounds good.

lincore81 on 3 Jun 2016

Those wanting to fix this, this line needs to be changed to:

A prime number is defined as a number greater than one and having only two divisors, one and itself. For example, 2 is a prime number because it's only divisible by one and two.

Please first read the contributing guidelines before taking care of this issue. And feel free to visit the Contributors Help chat room if you have any questions about helping. We're there to help.

erictleung on 3 Jun 2016

Hello Everyone!
I am new to FreeCodeCamp. can I take up this issue?

rohanricky on 3 Jun 2016

@rohanricky go for it!

erictleung on 3 Jun 2016

+1 here too!

jarrydfillmore on 3 Jun 2016

This issue is fixed in pull request #8968.

tjgerot on 5 Jun 2016

This hasn't been done, would you like me to take it? @erictleung

Grantlyk on 7 Jul 2016

@Grantlyk go for it! Please read the contributing documents I've linked above before taking up the issue. Let us know in the contributors Gitter room if you have any questions.

erictleung on 7 Jul 2016

This issue has been fixed according to what @erictleung asked in #9615