Foundation-sites: Reveal animation in doesn't work in 6.6.1

[Lazerproof]

What should happen?

Reveal opening should be animation with animation that set in a data attribute.

What happens instead?

Only reveal closing is animated.

Possible Solution

...

Test Case and/or Steps to Reproduce (for bugs)

https://jsfiddle.net/fxrwdvbe/ - 6.6.0 works
https://jsfiddle.net/L9tvkg07/ - 6.6.1 doesn't work

Your Environment

• Foundation version(s) used: 6.6.1
• Browser(s) name and version(s): Chrome 78.0.3904.108
• Device, Operating System and version: Win 10

Checklist

• [x] I have read and follow the CONTRIBUTING.md document.
• [x] There are no other issues similar to this one.
• [x] The issue title and template are correctly filled.

[DanielRuf]

Hi @Lazerproof,

Thanks for reporting this.
Can you provide codepen links instead of jsfiddle? That would be very helpful.

[DanielRuf]

In general your 6.6.0 version is in fact 6.5.3, see https://github.com/cdnjs/cdnjs/issues/13636

That's why we do not recommend cdnjs (you can try unpkg).

[vimalnair007]

Facing same problem after upgrading to 6.6.1, it was working fine with 6.5.3.

[DanielRuf]

Hi @vimalnair007,

can you provide a codepen which we can use as testcase? That would be awesome.

[DanielRuf]

I found the culprit using git bisect.

It seems the code was needed here but lacked a proper comment.
c9b7c7a3f4b517ef6e688886e503e2327d2f17ad

https://codepen.io/DanielRuf/pen/NWPbeaa

See also https://gist.github.com/paulirish/5d52fb081b3570c81e3a

[vimalnair007]

@DanielRuf I tested your fix by manually adding changes to foundation.min.js and animation working as expected on reveal.

Can you please add this changes to dist files as well?

Thank you for the fix and expecting PR to be merged soon.

[DanielRuf]

Can you please add this changes to dist files as well?

dist files are generally not updated in a PR. If needed I can provide patched dist versions.

We update dist files on prepublish / prepare.

[DanielRuf]

Depending on your project you can use git apply, patch or patch-package to apply the patches.

[vimalnair007]

Thanks for the information. Its okay, i have applied it manually for now in my project - hope it will not cause any problem. I wanted dist files in repo with final changes and prevent adding manual fix to keep remote and local files in sync.

I hope your changes will be part of next patch release dist after it is merged.

[DanielRuf]

I hope your changes will be part of next patch release dist after it is merged.

Yes, this is planned for the next patch release.

cc @joeworkman

[tlatsas]

Thank you for the fix! Any rough idea when the next patch version is expected?

[joeworkman]

This issue has been mentioned on Foundation Open Source Community. There might be relevant details there:

https://foundation.discourse.group/t/reveal-animation-in-bug/1780/2