Foundation-sites: [Visibility Classes] ISSUE NAME HERE

Created on 24 May 2016  路  4Comments  路  Source: foundation/foundation-sites

How can we reproduce this bug?

  1. http://foundation.zurb.com/sites/docs/visibility.html states following:
    "_Visibility classes use !important to ensure they aren't overriden by more specific selectors. This is the only component in the framework that uses !important_."
  2. http://foundation.zurb.com/sites/docs/drilldown-menu.html uses !important as well. Like:
    .is-drilldown li {
    display: block !important;
    }

What did you expect to happen?
I used class="show-for-medium" on a menu-item (<li>).

What happened instead?
It didn't work, because the use of 'block !important' within drilldown-menu

Test case:
Not available.

Give us a link to a CodePen or JSFiddle that recreates the issue.

scss 馃悰bug

Most helpful comment

I think we're able to just nix the !important and Drilldowns will still work.

All 4 comments

I think we're able to just nix the !important and Drilldowns will still work.

@andycochran Should be right

@coachie Are you able to remove the !important and see if it works as expected? If so we'd love to see a PR on this one! All for reducing specificity.

@andycochran @rafibomb That works fine with me! Thanks!

Hi, @gakimball. It was perhaps you who added that !important in #L31-L33. Was there any particular reason we should know about before nixing it?

Was this page helpful?
0 / 5 - 0 ratings