Foundation-sites: Wrong link in Off-canvas docs

Created on 3 Jul 2017  路  8Comments  路  Source: foundation/foundation-sites

How to reproduce this bug:

  1. Open the Off-canvas page in docs (http://foundation.zurb.com/sites/docs/off-canvas.html)
  2. Check the section Responsive Off-Canvas (http://foundation.zurb.com/sites/docs/off-canvas.html#responsive-off-canvas-putting-it-all-together-)
  3. Click on the link http://zurb.com/building-blocks/top-bar-with-off-canvas

What should happen:

Open proper page in building blocks.

What happened instead:

Opens the main page of building blocks.

I'm not able to find a proper page in building blocks. Is it possible that there isn't such a building block anymore?

Most helpful comment

@IamManchanda I'm sorry to say I'm an old guy, I just haven't been active for a while due to other issues. It's great to be able to contribute again.

I used to contrib under a different Github account though.

All 8 comments

Had a look at the building blocks page and I can't see a page that this should link to either.

@OndrejVasicek @codetheorist Would anyone of you want to submit a PR

A goodie link that could replace this would be http://foundation.zurb.com/building-blocks/blocks/multilevel-offcanvas-menu.html

YES! I hadn't seen that layout yet but that looks amazing.

@IamManchanda A PR has now been submitted.

You were faster :) Thank you.

Its amazing that all of you new guys are coming up with your skills :+1:
Keep coming up with your feedback... Its great for the framework's future! :)

@IamManchanda I'm sorry to say I'm an old guy, I just haven't been active for a while due to other issues. It's great to be able to contribute again.

I used to contrib under a different Github account though.

hahaaa in that case i am a newbie (which i am though :wink: )

Closing this as fixed in #10329 !

Was this page helpful?
0 / 5 - 0 ratings