Foundation-sites: $enable-cite-block is missing !default from scss

[alexkuc]

What should happen?

According to docs, it should be possible to disable styling of <cite>…</cite> tag using $enable-cite-block in _settings.scss.

What happens instead?

Foundation framework styles <cite>…</cite> tag regardless of the value of $enable-cite-block

Possible Solution

File scss/typography/_base.scss on the L200 is missing !default.

Test Case and/or Steps to Reproduce (for bugs)

How to reproduce:

1. git clone https://github.com/alexkuc/foundation-sites-cite-block-bug
2. yarn
3. yarn build
4. yarn start or use alternative hosting such as nginx or apache
5. navigate to http://localhost:8888/ in order to open index.html which should be:

but instead it is:

Context

Not possible to disable formatting of <cite>…</cite> so I guess the context is typograhpy / custom css?

Your Environment

• Foundation version(s) used: [email protected]
• Browser(s) name and version(s): Version 81.0.4044.129 (Official Build) (64-bit)
• Device, Operating System and version: OSX 10.13.61
• Link to your project: https://github.com/alexkuc/foundation-sites-cite-block-bug

Checklist

• [x] I have read and follow the CONTRIBUTING.md document.
• [x] There are no other issues similar to this one.
• [x] The issue title and template are correctly filled.

[DanielRuf]

Hi @alexkuc,

thanks for the hint. It seems it slipped through in https://github.com/foundation/foundation-sites/commit/c9fd9d7344cf3b391af75d5cf1d55dee8cd60282

And the same applies to $enable-code-inline.
Do you want to provide a PR which fixes this?

[alexkuc]

@DanielRuf I have created PR #12073. I hope I followed the format of the guidelines correctly (template and CONTRIBUTING.md). If I made a mistake, please let me know so I can fix it. Thank you!

[DanielRuf]

@alexkuc thank you for your contribution. I will check this when I find some time.