Foundation-sites: select icon in chrome

[captain-xu]

There two icons in chrome , the select should add -webkit-apperance: none

[Deckluhm]

As stated here, vendor prefixes aren't included in Sass sources.

[kball]

We can if necessary to fix a bug... can you put in a reproduction codepen?

[Deckluhm]

We can if necessary to fix a bug... can you put in a reproduction codepen?

The "bug" is only visible if you use the Sass version of Foundation (since there is no vendor prefixes in sources) and as far as I know, there is no easy way to import a full Sass project in CodePen.

I reproduced the "bug" @captain-xu is talking about by using Foundation CSS version and by setting select -webkit-appearance to the default WebKit value (menulist):

https://codepen.io/anon/pen/EmKZgW?editors=1100

[captain-xu]

@Deckluhm that's right, there are no problems if use the css. And I think, the select -webkit-appearance show be 'none'

[kball]

@IamManchanda I think this is similar to the fix you did in https://github.com/zurb/foundation-sites/pull/9868 - do you want to take a pass on it?

[IamManchanda]

Ohk @kball will take a look!

[IamManchanda]

@captain-xu @Deckluhm
I couldn't reproduce in the sass build codepen!
https://codepen.io/IamManchanda/pen/wdQVoB
(As this is a Sass Build with all of foundation code, codepen takes a bit of time to open)

Apart from that i have added test case here (where also i cant see the bug) https://github.com/zurb/foundation-sites/pull/10063
Can you pull it and let me know with screenshot and browser details ??

[rafibomb]

@Deckluhm Hmm, as far as I know, Autoprefixer is running on the ZURB Stack and Basic Template. You can see it here,
https://github.com/zurb/foundation-zurb-template/blob/master/gulpfile.babel.js#L84
https://github.com/zurb/foundation-sites-template/blob/master/gulpfile.js#L17

If you are not auto-prefixing, then manually adding the vendor prefixes would be good.

I am also seeing the correct declarations in my 6.3.1 project:

Unless I'm missing something, let me know - we'll close this.

[Deckluhm]

Hmm, as far as I know, Autoprefixer is running on the ZURB Stack and Basic Template.

Sorry if I wasn't clear enough, here are my thoughts about the issue reported:

• It's not a bug
• It only appears on Sass version without Autoprefixer, basically anything except ZURB Stack (e.g. foundation-rails gem)
• As stated in the docs, unless you are using the ZURB Stack (that already includes Autoprefixer), you must use Autoprefixer to get vendor prefixes

That is probably a good idea to add a small note in the docs about that. I already faced that "double icon" issue and it wasn't obvious that it was a prefixes issue.

[IamManchanda]

That is probably a good idea to add a small note in the docs about that. I already faced that "double icon" issue and it wasn't obvious that it was a prefixes issue.

@Deckluhm you are correct :+1: ..... Go ahead and add a PR :)