Flutterlocation: changeSetting API should use the dart Duration Type not an int

[ride4sun]

In order to have a self-describing robust API, the lib should use dart type Duration and not int
for the interval. Also, there is no description of what the int unit actually is. I guess ms
The duration can easily be converted back into int as needed for the call into the next layer.

  Future<bool> changeSettings({
    LocationAccuracy accuracy = LocationAccuracy.high,
    int interval = 1000,
    double distanceFilter = 0,
  }) {

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[ride4sun]

Is this lib maintained?

On Thu, Aug 13, 2020, 02:40 stale[bot] [e-mail] wrote:

This issue has been automatically marked as stale because it has not had
recent activity. It will be closed if no further activity occurs. Thank you
for your contributions.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Lyokone/flutterlocation/issues/392#issuecomment-673376087,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB3BZ2Y4OGU275EHL4H4UOLSAOYKHANCNFSM4OY74UWQ
.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[ride4sun]

This is really unprofessional closing defect because the maintainer is not reacting. I would advise people to use another lib. My 2 cents

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[ride4sun]

I think not this issue is stale. The library is stale. My 2 Cents. No
support here

On Wed, Oct 14, 2020, 21:13 stale[bot] [e-mail] wrote:

This issue has been automatically marked as stale because it has not had
recent activity. It will be closed if no further activity occurs. Thank you
for your contributions.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Lyokone/flutterlocation/issues/392#issuecomment-708885556,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB3BZ23MOPIENDP7JCNBAS3SKZZGXANCNFSM4OY74UWQ
.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[ride4sun]

Is there anybody maintaining this?

On Sun, Nov 15, 2020, 10:50 stale[bot] [e-mail] wrote:

This issue has been automatically marked as stale because it has not had
recent activity. It will be closed if no further activity occurs. Thank you
for your contributions.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Lyokone/flutterlocation/issues/392#issuecomment-727617545,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB3BZ253HIUOJWSMKTBT3X3SQAPFRANCNFSM4OY74UWQ
.

[Lyokone]

Hi, sorry for not responding for this long.
I'll check when I'll have time, If you feel like submitting a PR, It will be very much appreciated :)

[ride4sun]

Maybe you should switch the robot off and avoid that issues will be cleared out automatically without any responses.I look into sending a PR but I need your time to approve it

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[ride4sun]

any takers

On Thu, Dec 17, 2020 at 10:41 PM stale[bot] [e-mail]
wrote:

This issue has been automatically marked as stale because it has not had
recent activity. It will be closed if no further activity occurs. Thank you
for your contributions.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Lyokone/flutterlocation/issues/392#issuecomment-747901717,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB3BZ27JTRBINZEX5J62F4TSVL2QXANCNFSM4OY74UWQ
.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.