Flow-for-vscode: Flow works even if I don't use flow annotation

[svipas]

Hello,

Flow is working even if I'm don't using // @flow annotation...

When I delete that a; and save, errors disappears. And this happens for all .js documents, by the way the funniest part is, in [ignore] is this __tests__ dir, there's this file app.test.js, but I even tested with other .js files it's the same... So this plugin somehow ignores even [ignore] in .flowconfig and you don't need type // @flow or /* @flow */ to enable type check, funny :smile:

[svipas]

Also right now VS Code started to lag more, I think it's related...

[aeruhxi]

I've started to feel the lag too.

[patrickgordon]

I have the same issue. Extension is version 0.6.0

[svipas]

@patrickgordon Did you feel lag too?

[patrickgordon]

@svipben yes lagging a lot

[minedeljkovic]

Reason for lagging might be new "run on edit" feature.
You can turn it off in your vscode settings. See here

[aeruhxi]

@minedeljkovic Thanks! Yeah, "run on edit" was the problem for lag. But the plugin stills checks files without flow annotation.

[svipas]

@minedeljkovic I will try that, but I think they are related, also not lag is the problem, but Flow check works even if there's no // @flow annotation, so there's 2 problems, lagging and checking without // @flow annotation. By the way, if this option causing some lag, why it's turned true by default? :smile:

[aeruhxi]

Yeah, "run on edit" should be turned off by default or should be debounced.

[svipas]

@AbsoluteZero273 I agree 100%.

[svipas]

Memory and process usage is really huge, I hear how my laptop fan is working very fast :smile: Better really make that run on edit off by default or fix it, if it has problems.

[orta]

Sounds reasonable, someone want to send a PR?

[aeruhxi]

@orta PR to disable it by default or something more?

[svipas]

@AbsoluteZero273 I think he's talking about whole problem related with this option (run on edit) and by flow working even if there's no annotation. Because to disable run on edit by default it's pretty easy, just edit package.json file :smile:

[orta]

I've shipped the package.json change in #120

[thymikee]

PR addressed

[svipas]

@thymikee Nice!