Flow-for-vscode: IntelliSense mixed with word-based suggestions

Created on 28 Mar 2017  路  4Comments  路  Source: flowtype/flow-for-vscode

First of all thanks for creating this great extension 馃槃, just one little thing that bugs me a bit:

When using Flow, there are a lot of word-based suggestions mixed with the Flow-based IntelliSense (see screenshot below) which makes exploring richer object structures more tedious. In TypeScript on the contrary VS Code does not show any word-based suggestions.

Is the a reason for showing them and if not is it possible to turn them off?

Besides I noticed in this example that label is shown twice.

screen shot 2017-03-28 at 11 00 46 am

TypeScript example:
screen shot 2017-03-28 at 11 05 05 am

Sample code for MainNav.jsx used for screenshot:

// @flow

import React, { PureComponent } from 'react';

type DummyType = {
  /** Name for menu item */
  label: string;
  /** Url for link */
  url?: string;
}


class MainNav extends PureComponent {
  props: {
    test: DummyType
  }

  render() {
    const {test} = this.props;

    return (
      <div>
        {test.label}
      </div>
    )
  }
}

export default MainNav

Versions:
VS Code: 1.10.2
flowtype.flow-for-vscode: 0.5.0

All 4 comments

Thanks for the great issue, I'm afraid it's a dupe of https://github.com/flowtype/flow-for-vscode/issues/97

I'm not sure if anyone has specifically explored the "remove the words used in the file" as I wonder if that comes from the default JS implementation. You're welcome to take a stab at seeing if that is feasible.

The 'words used in the file' suggestions also come from TypeScript, so they're the same issue. I've taken to just deleting the typescript extension folder but that's clearly not an optimal solution.

I think we can close this now as a new option javascript.nameSuggestions was shipped in the latest VSCode version: https://github.com/Microsoft/vscode/commit/4514ddd1807ac3b90e65b98da981ab1a8f59f3a0.

馃憤 agree

Was this page helpful?
0 / 5 - 0 ratings

Related issues

vojtatranta picture vojtatranta  路  4Comments

dnepro picture dnepro  路  5Comments

wbinnssmith picture wbinnssmith  路  5Comments

tomitrescak picture tomitrescak  路  7Comments

spudly picture spudly  路  6Comments