Flex-layout: Orientation media queries defined in orientation-break-points.ts seem to be using incorrect pluralisation

Created on 7 Jun 2018  路  3Comments  路  Source: angular/flex-layout

Bug, feature request, or proposal:

I think there is a bug in the file src/lib/core/breakpoints/data/orientation-break-points.ts

What is the expected behavior?

The media queries in there use (orientations: ...) rather than (orientation: ...) - note the pluralisation in the word orientations. I believe the singular form is the correct version, see here: https://developer.mozilla.org/en-US/docs/Web/CSS/@media/orientation

What is the current behavior?

What are the steps to reproduce?

What is the use-case or motivation for changing an existing behavior?

To improve the product

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Is there anything else we should know?

P1 bug has pr

All 3 comments

Thanks for finding this, it should be patched by #765

@Mufasa - great catch. Thank yo.

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_This action has been performed automatically by a bot._

Was this page helpful?
0 / 5 - 0 ratings