Flex-layout: is ngClass really merging correctly?

Created on 17 Jan 2018 · 3Comments · Source: angular/flex-layout

Bug, feature request, or proposal:

Bug?

What is the expected behavior?

On gt.md both class "desktop" and "background-image" should be present.. right?

What is the current behavior?

looks like only gt-sm is used

What are the steps to reproduce?

https://stackblitz.com/edit/angular-flex-layout-seed-b3yp5n?file=app/test.component.ts

discussion question

Source

mackelito

Most helpful comment

ngClass.<suffix> is designed to merge with existing ngClass declarations, not other responsive declarations. For this, we use a fallback algorithm to decide which directive is active at a given time.

It's worth discussing possibly merging these values as an exception for ngClass, but there are definitely arguments for both sides.

CaerusKaru on 18 Jan 2018

👍2

All 3 comments

It's worth discussing possibly merging these values as an exception for ngClass, but there are definitely arguments for both sides.

CaerusKaru on 18 Jan 2018

👍2

hmm.. well It was just not what I expected but now I'm not sure if a change is needed.. perhaps if a more clear example arises then we might revisit this issue.. :)

mackelito on 22 Jan 2018

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{_This action has been performed automatically by a bot._}