Flex-layout: chore: deprecate fxLayoutWrap

[CaerusKaru]

The FlexLayoutWrapDirective has been deprecated since at least beta.10. It is slated to be removed with the next release.

[aldo-roman]

is there any docs regarding the deprecation of [fxLayoutWrap]? I cannot find them in the changelogs.

[CaerusKaru]

It’s not in the CHANGELOG for some reason, but it is in the source for the directive. If you open up the source in an IDE, for instance, you would immediately see that it’s been marked as deprecated, and for a while.

[lebnic]

The link https://github.com/angular/flex-layout/wiki/fxLayoutWrap-API (found in this repo's wiki) for layoutWrap does not work ...

Maybe wiki's doc should be update to remove any mention of layoutWrap (eg: https://github.com/angular/flex-layout/wiki/API-Documentation)

[CaerusKaru]

The docs will be updated after the API is removed.

[RoestVrijStaal]

@CaerusKaru @ThomasBurleson
https://archive.fo/KbHrX Oh-Oh! Someone did not do his job and this ticket got closed without result verification :sob:

And there is zero documentation about that new 'wrap' keyword for fxLayout https://github.com/angular/flex-layout/wiki/fxLayout-API#fxlayout-options

[CaerusKaru]

@RoestVrijStaal lack of documentation is not a lack of verification. On the master branch, it is not uncommon for features to be released without documentation. In fact, it is commonly the last thing to be added before the next published release. You can see that #540 will include the documentation updates you are so worried about.

Current documentation for the wrap option, which is documented in the code, is also available on this page. Currently not the easiest to find, and will be fixed in #540, but definitely not impossible to find.

Also, independent documentation PRs are very much welcome.

[RoestVrijStaal]

Current documentation for the wrap option, which is documented in the code, is also available on this page. Currently not the easiest to find, and will be fixed in #540, but definitely not impossible to find.

Sounds promising but when I look there:

| HTML API     | Allowed values |
|--------------------|-------------------------------------------------------------------------|
| fxLayout | <direction> \| <direction> <wrap>
Use: row \| column \| row-reverse \| column-reverse

It isn't there?

I think you're pointing at a version of that page in a branch which isn't public yet.

[CaerusKaru]

Under allowed values, it’s the thing that says <wrap>

[martinsik]

I just stumbled upon this. It's not mentioned in the CHANGELOG.md at all that fxLayoutWrap was removed.

[damoncasale]

What are the valid values for ? nowrap doesn't seem to be working for me.

[crowmagnumb]

Well <wrap> in the docs doesn't make any sense unless you also provide the valid values. Thankfully they have since updated the docs to read [wrap] to make it clear that "wrap" is the only valid value here. "nowrap" is the default.

[simeyla]

I wish this had been set to give an error:

[simeyla]

Just to be clear - do this now:

 fxLayout="row wrap"

Not this:

 fxLayout="row"
 fxLayoutWrap

[spottedmahn]

I just stumbled upon this. It's not mentioned in the CHANGELOG.md at all that fxLayoutWrap was removed.

@martinsik - looks like it got updated 😊

CHANGELOG.md#breaking-changes-1

[spottedmahn]

wiki/fxLayout-API documentation updated 😊 thanks to @ThomasBurleson!

Related issue: https://github.com/angular/flex-layout/issues/740

[spottedmahn]

I feel like it should also be mentioned on the API Doc page too.

Thoughts?

[angular-automatic-lock-bot[bot]]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{_This action has been performed automatically by a bot._}