Fisher: Updated time incorrect on fisher v3.0.8

Created on 8 Oct 2018  ·  11Comments  ·  Source: jorgebucaran/fisher

image

Recently updated fisher to 3.0.8 (which seemed to fix the --complete issues), but a minor bug is that the time displayed seems to be not subtracting date +%s epoch, and shows what looks like a timestamp.

bug

Most helpful comment

Let me know if you manage to get root access so that I can protect against that in the future :P

All 11 comments

@norcalli OS and fish version, please.

@norcalli ...which seemed to fix the --complete issues

That's a V2 to V3 upgrade issue. I'll add it to the guide. If you still see it remove the completions file:

rm -f ~/.config/fish/completions/fisher.fish
OS: Arch Linux x86_64
Host: Inspiron 5675 1.1.2
Kernel: 4.18.10-arch1-1-ARCH
Shell: fish 2.7.1
fisher version 3.0.8 ~/.config/fish/functions/fisher.fish

@norcalli Thank you.

Please run and show me the output of the following command.

date +%s%N

and

date +%s%3N
~
❯ date +%s%N
1539045791962453044

~
❯ date +%s%3N
1539045796379

~
❯ bash
[ashkan@ashkan ~]$ date +%s%3N
1539045800006
[ashkan@ashkan ~]$ date +%s%N
1539045804881464253

@norcalli Interesting. Could you also run this and show me the output?

set -l start (date "+%s%3N" | awk '{ sub(/%?3N$/,"000"); print $0 }')

sleep 1 # or wait a few seconds

date "+%s%3N" | awk "{ sub(/%?3N\$/,\"000\"); print (\$0 - 0$start)/1000 }"
❯ set -l start (date "+%s%3N" | awk '{ sub(/%?3N$/,"000"); print $0 }')

  sleep 1 # or wait a few seconds

  date "+%s%3N" | awk "{ sub(/%?3N\$/,\"000\"); print (\$0 - 0$start)/1000 }"

1.53889e+09

I created a user for you on my machine if you'd like to play around with. I authorized it with your public github keys, so you should be able to ssh in from any machine that has github access.

ssh [email protected]

The default shell is fish.

Let me know if you manage to get root access so that I can protect against that in the future :P

@norcalli Time should be displayed correctly now (55b543e). Please update to the latest fisher.

fisher self-update

Works! Thanks!

Was this page helpful?
0 / 5 - 0 ratings