Fisher: main branch compatibility with packages

Created on 1 Aug 2020  路  7Comments  路  Source: jorgebucaran/fisher

With github transitioning to using main as the default default branch, Fisher should default to main first and then master if that is not available.

Most helpful comment

I would also like to note that install and self-update are broken right now because of the branch name change...

All 7 comments

Done. It would be nice to come up with a different idea for the demo package in fisher#creating-your-own-package too. That didn't age well!

Oh @jorgebucaran I believe you misinterpreted me. I don't care whether fisher uses master or main as it's default branch, but that when installing a package it will accept both. Right now it defaults to master, but it should also check main.

I was planning on doing that someday anyway. But you are absolutely right, support for this soon should land soon, before Fisher 4.

I would also like to note that install and self-update are broken right now because of the branch name change...

@jorgebucaran Yah fisher cant be installed right now that should probably be hotfixed.

Hotfix landing soon. As for the branch issue, people can always install from a different branch or tag using:

fisher add username/repo@branch_or_tag

The easiest way to handle this would be to download main by default without a fallback to master as users that want to install from master can just:

fisher add username/repo@master

A more elaborate solution would be to add code to fallback to master for few months.

Please upgrade to 3.3.0 and help me identify any bugs. 馃挴

Was this page helpful?
0 / 5 - 0 ratings