Fightpandemics: Add new Feature: Share FightPandemics website posts to the social media

Created on 30 Jun 2020  路  28Comments  路  Source: FightPandemics/FightPandemics

As a FightPandemics website's user, I want to be able to share blog posts to the social media, so that I can discuss the content with my friends.

Acceptance Criteria:

  1. The open graph tags are added to the posts.
  2. There are tags for the following properties: url, type="website", description, image
  3. The Links are tested on the Facebook Sharing Debugger
  4. the Sharing functionality works on Facebook, Twitter.

Tags:




URL: https://staging.fightpandemics.work/post/5eff719ceea6cd0012b5d96c

BACKEND FRONTEND MVP - Release 1 P4 question

All 28 comments

@ppagarawal @indirabhowmick @vikjoshi I believe this should be prioritized for the MVP launch and not the Soft Launch.

Thoughts?

@pthoma14 Can I know why this is not MVP-Critical? I mean what is the difference between MVP - Release 1 and MVP-Critical?

Hi @WafaaAly,

The "MVP-Critical" tag = Soft Launch Features (Alpha Launch)
The "MVP-Release 1" tag = MVP Launch Features (Beta Launch)

For the Product team we are prioritizing which features are absolutely critical for the Soft Launch as we approach a code-freeze this upcoming Monday. Therefore a new feature like this I believe is Critical but for the MVP Launch (V1.1 or V1.2 release)

@ppagarawal @indirabhowmick @vikjoshi I believe this should be prioritized for the MVP launch and not the Soft Launch.

Thoughts?

You're correct @pthoma14

Hey @ppagarawal @pthoma14 @WafaaAly there was a similar issue reported last week (the title wasn't fully descriptive so I updated it). I will close this one in favor of the original #853

@joshmorel I don't think they are the same. the title of the mentioned one is still indicating that 'no links to social media'.
Unlike issue853, there is no design for this feature yet.
Again, In here we are not only copying the content. Please read the details.

Also, I would appreciate if we have a discussion before closing the issue :)

@WafaaAly you are totally right. I'm sorry I didn't read the details more carefully. I'm wondering if title would be better - "add social media header meta tags".

The title made me immediately thing of the other issue about a button to share to various sites.

@joshmorel The target of this is to share to Facebook for example unlike the other User Story.
To share to Facebook and the different sites we need to have the tags.
So adding the tags is only a part of it.
Clear now?

Again, I would appreciate if we have a discussion about things first and _I will_ apply the changes we agree upon.

Also, I don't know how well this might work without using SSR like Next.js OR maybe rendering metadata only for social media crawlers... So this will be hard based on where we are right now but definitely necessary in the long run. I will ask in our F/E channel for ideas, maybe not "MVP - Release 1".

Apologies for closing without discussing and I will change the title back so you can edit.

This is still not clear:

To share to Facebook and the different sites we need to have the tags.
So adding the tags is only a part of it.

I will leave it to you to update title & description to better outline what is all required here.

I will add the question label now when further information is required.

@joshmorel metadata for social media crawlers that we need are the Open Graph/OG meta tags.

Are you a back-end developer?

I will ask in our F/E channel for ideas, maybe not "MVP - Release 1".

what is the F/E channel?

This is still not clear:
To share to Facebook and the different sites we need to have the tags.
So adding the tags is only a part of it.

We can a call to discuss that.

Can we please prioritize this feature for a release first? I donot think there is a design for it yet. Thanks!

@indirabhowmick I asked for a designer in the standup today, and asked Yu for one too. Still couldn't get one yet.
For the priority I think it's MVP - Release 1, or what do you think?

I think we can implement with MVP 1.1 or 1.2 @vikjoshi @pthoma14 @ppagarawal - what are your thoughts?

I think we can implement with MVP 1.1 or 1.2 @vikjoshi @pthoma14 @ppagarawal - what are your thoughts?

We can have it in later releases as well.

@indirabhowmick yea I think it will also depend on when we can get the design team to take a look into this

@indirabhowmick yea I think it will also depend on when we can get the design team to take a look into this

@pthoma14 So, how long does it take to do so normally?

@indirabhowmick yea I think it will also depend on when we can get the design team to take a look into this

@pthoma14 So, how long does it take to do so normally?

I'm not sure how long their process is normally but they are actively trying to onboard more help.

@WafaaAly @indirabhowmick @pthoma14 @ppagarawal - agreed that this would be a great way to grow the platform and something @manualzuru and I had discussed a while ago as well. However, I dont think we can prioritize it for soft launch given the work involved.

I think we should include it on the list of potential items for MVP-v1 launch and have the discussion on whether to implement for MVP or not based on the other items in our MVP Backlog. In the meantime, @WafaaAly , please work with the Design team to spec this out so if we decide to implement for MVP, an engineer can pick it up and start working on it right away.

@vikjoshi I couldn't get a designer till now, can you help with that?
Also, @joshmorel introduced that it might not be straightforward, so I want a front-end dev from now to develop a POC that highlights the challenges in this feature _if any_.

Beat me to it @WafaaAly . Getting some design work started wouldn't hurt but work can be started on getting tags working with our React SPA code base. I asked in frontendengineering channel for help.

@vikjoshi Is this part of posts feature pod?

@joshmorel @WafaaAly - yeah I would think it would be part of the posts feature pod. Like Phil mentioned, the Design team may be a bit backed up given that they do not have too many folks and are onboarding new people.

@vikjoshi do you mean this Pod MVP - Create/Edit Post, I can't edit it.

I will close this once I confirm #1378 works in production.

This works

image

HOWEVER, SEO4Ajax stopped crawling after 14 posts. It crawled 40 total results then stopped (final 15 were profile links then). This likely can be fixed in SEO4Ajax settings - not our code/config.

I might need to dynamically generate a sitemap.xml - https://github.com/kuflash/react-router-sitemap

Hey @joshmorel , is this already implemented or are we need to work on it? For now just adding P4 label.

Hey @tejasm2 - this is implemented just need to resolve the issue above.

I can create a new specific issue.

Was this page helpful?
0 / 5 - 0 ratings