Fiddle: Changing electron version reloads the default fiddle

[nornagon]

To repro:

1. load a fiddle
2. change the electron version with the selector in the top-left

Expected behavior:

Fiddle contents remains unchanged

Actual behavior:

Fiddle contents replaced with default fiddle

[codebytere]

@nornagon what version of Fiddle? what versions are you switching between? I can't repro this on macOS with 0.22.0 when switching between for example a v14 nightly and a v10 version 🤔

[erickzhao]

I believe I've encountered this before, I'll try to reproduce as well.

[nornagon]

v0.22.0, and switching between any version of Electron did it. It doesn't seem to be reproducing any more though 🤔

Pretty sure it's a real bug that's still around though, I'm not sure exactly what circumstances bring it about.

[nornagon]

I'm able to reliably reproduce this still in v0.25.1.

Steps:

1. Launch Electron Fiddle
2. Paste https://gist.github.com/dachuanhouhou/37055f48d16c97dc4e6f47b241a8898f into the "Load Fiddle" box
3. Click "Load Fiddle"
4. Change versions

the default fiddle will be re-loaded.

I think some logic here must be at fault?

https://github.com/electron/fiddle/blob/fba74a86c46c27d2c8ad1b74726c163e28af673d/src/renderer/state.ts#L489-L495

cc @ckerr who touched that code recently.

[ckerr]

I believe this is working in main and that what's happening is that 0.25.1 mistakenly didn't include the code you're linking.